Modify

Opened 6 years ago

Last modified 6 months ago

#12493 new enhancement

[PATCH] Categorize 'Way end node near other highway' warnings.

Reported by: maxerickson@… Owned by: team
Priority: minor Milestone:
Component: Core validator Version:
Keywords: way end node group Cc:

Description

In areas with (for example) poorly drawn sidewalks, the results of the 'Way end node near other highway' validation are dominated by footways that are not connected to streets or service roads. Fixing the sidewalks is not always a priority and it is anyway often better to contact the original mapper and encourage them to adjust what they are doing than it is to just fix the problem.

It would useful if the warnings were sorted into categories. I think major/minor would be enough, but it looks like one category per highway type (chosen from the way with the end node) would be easier to implement.

Attachments (2)

12493_v1.patch (2.5 KB) - added by reichg 9 months ago.
Categorizes warning by end node's parent way highway tag.
12493-2.patch (2.1 KB) - added by GerdP 7 months ago.
proposed solution

Download all attachments as: .zip

Change History (17)

comment:1 Changed 2 years ago by skyper

Keywords: way end node group added

comment:2 Changed 9 months ago by reichg

Can we get some examples of this please?

comment:3 Changed 9 months ago by reichg

Can you explain how you think these warnings should be categorized? We can try the major/minor outcome you desire, just need to get an idea of how these should be categorized.

Something like this??

Major: Motorway, Trunk, Primary
Minor: Any highway value below Primary?

comment:4 Changed 9 months ago by maxerickson@…

To me the useful categories are probably something like pedestrian, bicycle, minor road and major road, with major road being tertiary and above (collector streets and highways where connectivity is more impactful) and minor road being everything else.

For just 2 categories it would be the collector streets and above for major and everything else for minor.

I typically would always fix major road issues and bicycle issues and am less likely to fix minor road and pedestrian issues.

comment:5 Changed 9 months ago by skyper

I am often not happy with the sorting of validator results but I did not figure out how the best sorting would look like and it might depend on the test/rule itself and the users workflow. This is a more general problem and better discussed in a new ticket though.

Coming back to this ticket I would start with two categories, motorway to residential/unclassified and the second category everything from service on below.
Additionally, sorting the results could be done by name=*, highway=* and ref=* and even the location could be used if name and ref are missing to get all nearby problems in a group.

comment:6 Changed 9 months ago by reichg

When we say categorize, can major/minor simply be a difference in severity (WARNING/ERROR)

comment:7 Changed 9 months ago by skyper

Please, no error. How about just splitting into two warnings, one for each category.

comment:8 in reply to:  7 Changed 9 months ago by reichg

Replying to skyper:

Please, no error. How about just splitting into two warnings, one for each category.

Yeah not a problem. The solution ended being very simple I think. Just get the highwayTag from the nearby end node's parent way. I check that tag against a set of priority highway tags -> priorityHighwayTags which consists of MOTORWAY, MOTORWAY_LINK, TRUNK, TRUNK_LINK, PRIMARY, PRIMARY_LINK, SECONDARY, SECONDARY_LINK, TERTIARY, TERTIARY_LINK, RESIDENTIAL, UNCLASSIFIED. If the set contains the highway tag then the warning is Major (just a different message).

Changed 9 months ago by reichg

Attachment: 12493_v1.patch added

Categorizes warning by end node's parent way highway tag.

comment:9 Changed 9 months ago by reichg

Summary: Categorize 'Way end node near other highway' warnings.[PATCH] Categorize 'Way end node near other highway' warnings.

comment:10 Changed 8 months ago by reichg

Does the patch solution satisfy the ticket?

comment:11 Changed 8 months ago by reichg

Milestone: 21.09

comment:12 Changed 8 months ago by Don-vip

Milestone: 21.0921.10

Milestone renamed

comment:13 Changed 7 months ago by GerdP

I am not convinced this distinction makes much sense.

The patch doesn't work as intended when many issues are found as it changes the message string to "Major" for all following unconnected nodes.
Other minor issues:

  • I don't like the idea of using toUpperCase() for tag values.
  • Can't we use the existing list CLASSIFIED_HIGHWAYS in Highways.java? It also contains "living_street"?

My understanding is that the "- Major" suffix should be added if both highways are major, not just the one with the unconnected node? So, if a footway ends near a primary or a residential ends near a footway, both are minor issues, right?

Changed 7 months ago by GerdP

Attachment: 12493-2.patch added

proposed solution

comment:14 Changed 7 months ago by GerdP

Milestone: 21.10

comment:15 in reply to:  13 Changed 6 months ago by reichg

Replying to GerdP:

I am not convinced this distinction makes much sense.

The patch doesn't work as intended when many issues are found as it changes the message string to "Major" for all following unconnected nodes.
Other minor issues:

  • I don't like the idea of using toUpperCase() for tag values.
  • Can't we use the existing list CLASSIFIED_HIGHWAYS in Highways.java? It also contains "living_street"?

Tested your patch with these changes?


My understanding is that the "- Major" suffix should be added if both highways are major, not just the one with the unconnected node? So, if a footway ends near a primary or a residential ends near a footway, both are minor issues, right?

Works for me!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to maxerickson@gmail.com
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.