harmonize warning message with button caption

[kolesar]

What steps will reproduce the problem?

1. Open preferences, set expert mode.
2. Switch to Einstein preferences.
3. Press Reset button.

What is the expected result?

Something will be reseted.

What happens instead?

Warning message: "Please select the row to delete." Delete??? I wanted to reset something, not delete.

Please provide any additional information below. Attach a screenshot if possible.

I understand that preferences file stores overridden settings only and reset means deleting the corresponding override from preferences file. Users may be confused with reset / delete.

Attached patch that modifies message to "Please select the row to reset.".

Question: Is it the best way to leave a button enabled and show a warning message if pressed in a situation where it is not applicable? I think disabling Reset button would be better until a row is selected. Tooltip message can help user what will enable this button.

What do you think? (This button is marginal, question scope is global.)

[bastiK]

In general, if a button is not applicable, it should be disabled. There may be reasons to deviate from this rules, but not in this case.

[bastiK]

Patch needs rework.

[simon04]

In 16844/josm:

fix #12484 - Disable inappropriate AdvancedPreference actions

Edit requires exactly one selected row.
Reset requires at least one selected row.