Modify

Opened 3 years ago

Closed 3 years ago

#12422 closed enhancement (fixed)

remove lit on suspicious object warning

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 16.02
Component: Core validator Version:
Keywords: lit Cc:

Description

In the past we added more and more exceptions to the lit rule. However as already said in one of those tickets, anything can be lit. So I suggest to turn this warning into a "incomplete object: only lit" warning. (We already have this warning for are, name and ref)

This reduces the number of false positives validator warnings and reduces the chance that users disable the validator because of false positives. See also this poll (german).

*[lit][eval(number_of_tags()) = 1] {
  throwWarning: tr("incomplete object: only {0}", "{0.key}");
}

Attachments (0)

Change History (4)

comment:1 Changed 3 years ago by Don-vip

Keywords: lit added

These combinations do not make sense:

  • landuse=* + lit=yes
  • boundary=* + lit=yes
  • place=* + lit=yes

These ones are unlikely to exist:

  • waterway=* + lit=yes
  • natural=water + lit=yes
  • natural=wood + lit=yes
  • power=tower + lit=yes
  • power=pole + lit=yes

I like the idea of the new warning.

I don't know if the existing one should be improved or removed. The examples that I thought of... do not seem to occur in the database, so the warning is maybe not needed at all.

Some questions:

  • what was the false positive about in your link? (don't speak German)
  • can we find an actual error in the OSM database?

comment:2 in reply to:  1 Changed 3 years ago by Klumbumbus

Replying to Don-vip:

  • what was the false positive about in your link? (don't speak German)

It was not about lit, but how users use the validator in general. I create this poll when this poll website was new developed in april 2015.

  • 1 user (0.9%) chose "I disabled the validator completey"
  • 6 users (5,3%) chose "I mostly ignore the validator, because I don't undertand the validator messages or I don't know how to fix the error."
  • 6 users (5,3%) chose "I mostly ignore the validator, because it produces too much false positives."

Deactivating or ignoring the validator is not good, so I try to reduce the number of false positives.

comment:3 in reply to:  1 Changed 3 years ago by Klumbumbus

See the following examples, where I cannot say that they are tagged wrong:


  • waterway=* + lit=yes
    • only 27 objects, most of them waterway=dam (which is legit)

(I skipped the rest)

I transformed our validator warning into a overpass search http://overpass-turbo.eu/s/dVQ, to see what is fetched by our rule. The vast majority of objects I checked are either legit or have only lit with no other tag. (There were a few, where it seems that the highway=* tag was missing.)

Last edited 3 years ago by Klumbumbus (previous) (diff)

comment:4 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 9837/josm:

fix #12422 - remove "lit on suspicious object" warning and replace by "incomplete object: only lit" warning

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.