Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12389 closed defect (needinfo)

Poor performance when panning

Reported by: ToeBee Owned by: nokutu
Priority: normal Milestone:
Component: Plugin mapillary Version:
Keywords: Cc:

Description

This may just be #11929 not really being fixed but I suspect the root problem may be something else. I did see the .equals method being executed a lot but I think something is causing the draw method to be called an excessive number of times so I think the equals method being called a lot is just a side effect. I added a counter in the draw method to see how often it was getting called and every time the map view changes, it increments by about 12,000 in my case. At an execution time of 25 microseconds each time draw is called, that results in 300ms spent in the draw method. Add in some additional time in whatever calls draw and you're looking at a 500+ millisecond pause every time you pan.

An easy place to test this is highway 96 in Kansas. Someone uploaded about 10 sequences between Hutchinson and Wichita so there are a lot of pictures to load:
http://www.openstreetmap.org/#map=13/37.8668/-97.6401

Attachments (0)

Change History (2)

comment:1 Changed 5 years ago by nokutu

Resolution: needinfo
Status: newclosed

Hi

I've improved the paint method by avoid to draw the images that are not in the screen. Can you tell me if the attached jar goes faster in your computer?

Thanks

Jorge

Last edited 5 years ago by nokutu (previous) (diff)

comment:2 Changed 5 years ago by ToeBee

It does help when zoomed in at the editing level so that's good. Obviously if I'm zoomed out trying to find my next place to edit, things are still kind of sluggish. However looking at CPU usage, this might be a deficiency in JOSM itself. With the Mapillary layer hidden, I can get JOSM to suck up a whole core by panning quickly. So adding a second layer to render will undoubtedly impact performance...

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain nokutu.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.