[patch] remember user input when upload dialog is closed

[kolesar]

I often find myself in a situation: finished editing, pressed upload, filled changeset comment and source fields, double checked everything and something came into my mind. Pressed cancel (or simply closed dialog), made some changes on map and pressed upload again. I have seen sadly that changeset comment and source was discarded.

Workaround was boring: before closing dialog copied changeset comment, pasted into my favourite text editor, copied source field, pasted again. Next time I copied+pasted them back.

I have simply reversed order of two lines in UploadAction in order to save these fields when dialog was closed without uploading: moved dialog.rememberUserInput() before exiting on cancel.

If you are not sure if it is a good idea to keep data on cancel, see ChangesetManagementPanel. Toggling chechbox "Close changeset after upload" saves new value in preferences immediately.

This patch unifies the behavior of keeping valuable data even when upload action was not performed. Settings on UploadStrategySelectionPanel are also saved.

[bastiK]

In 9462/josm:

applied #12367 - remember user input when upload dialog is closed (patch by kolesar)

[aceman]

Finally ! :)