Reverting objects with deleted data isn't ideal

[naoliv]

Download object w233056719.
Select it and revert changeset 36536612, with "Revert selection only"
When asked to download objects outside the current dataset, say Yes.

Note how nothing changed.

Now with the same object selected choose "Revert selection and restore deleted objects".
The object is properly restored to its previous version but with one detail: every other deleted node is also restored, even the ones not related with this object.

It should undelete and restore only the related objects.

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-13 03:32:00 +0100 (Wed, 13 Jan 2016)
Build-Date:2016-01-13 02:34:25
Revision:9430
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9430 en) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 952 MB / 9102 MB (603 MB allocated, but free)
Java version: 1.8.0_72-internal-b05, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
- Create_grid_of_ways (31772)
- OpeningHoursEditor (31772)
- PicLayer (31895)
- RoadSigns (31895)
- SimplifyArea (31895)
- apache-commons (31895)
- buildings_tools (31895)
- conflation (0.1.9)
- contourmerge (1014)
- download_along (31772)
- editgpx (31772)
- ejml (31895)
- geotools (31895)
- imagery_offset_db (31895)
- importvec (31772)
- jts (31772)
- log4j (31895)
- measurement (31895)
- merge-overlap (31967)
- opendata (31937)
- pbf (31772)
- pdfimport (31895)
- poly (31772)
- reverter (31926)
- scripting (30722)
- todo (29154)
- turnrestrictions (31895)
- undelete (31895)
- utilsplugin2 (31895)

Last errors/warnings:
- E: Unable to revert {Way id=233056719 version=1 VT nodes=[{Node id=2413968753 version=0 IV lat=51.6383676,lon=17.7840339}, {Node id=2413968745 version=0 IV lat=51.6383229,lon=17.7839461}, {Node id=2413968756 version=0 IV lat=51.6383834,lon=17.7838661}, {Node id=2413968770 version=0 IV lat=51.6384281,lon=17.783954}, {Node id=2413968753 version=0 IV lat=51.6383676,lon=17.7840339}]} as it produces 0 nodes way {Way id=233056719 version=2 VT nodes=[]}

There are some errors ↑↑↑ but I don't know if they are related.

[Nakaner]

I have the same version of Reverter plugin as above and experienced a similar problem.

What steps will reproduce the problem?

1. Open JOSM, create new empty data layer.
2. Revert changeset 36616461 (it is huge). The use added tags to lots of ways and nodes in this changeset (but used a source without permission).
3. Search for modified objects.

What is the expected result?

The Reverter plugin should remove the tags the user added to nodes and ways.

What happens instead?

The Reverter plugin only removed his tags from ways. It did not touch nodes (Ctrl + F → "modified") does not highlight any nodes, only ways.

I tried to reproduce this behaviour with smaller changesets (I tried some changeset which modified both ways and nodes and changesets which modified only one node) but could not reproduce this behaviour. Sorry, that I cannot provide you a minimal working example. :-(

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-06 17:30:31 +0100 (Wed, 06 Jan 2016)
Build-Date:2016-01-06 16:32:31
Revision:9329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9329 de) Linux Arch Linux
Memory Usage: 800 MB / 1746 MB (114 MB allocated, but free)
Java version: 1.8.0_66, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Djosm.restart=true]
Dataset consistency test: No problems found

Plugins:
- Mapillary (31976)
- apache-commons (31895)
- apache-http (31895)
- buildings_tools (31895)
- reverter (31926)
- terracer (31895)
- utilsplugin2 (31895)

Last errors/warnings:
- E: Defekte Objektvorlage "railway:signal:departure:states-Anzeigbare Signalbilder" - Anzahl der Datenworte in 'display_values' und in 'values' müssen gleich sein
- E: Detaillierte Information: [A 1 (Türen schließen);A 2 (Abfahren), A 1 (Türen schließen);A 2 (Abfahrt)] <> [DE-BOStrab:a1;off, DE-BOStrab:a2;off, DE-BOStrab:a1;DE-BOStrab:a2;off]
- W: Cannot start IPv4 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
- W: Cannot start IPv6 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect

[Nakaner]

Because I wanted to do a partial revert, I had to use JOSM. I tried an old version of JOSM and an old version of the revert plugin and the bug also occured.

I tried to revert changeset 36727840, but after the revert no objects were modified (searching for modified objects returns 0 results).

Revision: 8677
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2015-08-21 22:18:03 +0200 (Fri, 21 Aug 2015)
Build-Date: 2015-08-21 23:32:08
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8677

Identification: JOSM/1.5 (8677 de) Linux Arch Linux
Memory Usage: 222 MB / 1746 MB (46 MB allocated, but free)
Java version: 1.8.0_66, Oracle Corporation, OpenJDK 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- Mapillary (31976)
- apache-commons (31895)
- apache-http (31895)
- buildings_tools
- reverter (31895)
- terracer
- utilsplugin2

Last errors/warnings:
- W: Cannot lock cache directory. Will not use disk cache
- W: Cannot start IPv4 remotecontrol server on port 8111: Die Adresse wird bereits verwendet
- W: Cannot start IPv6 remotecontrol server on port 8111: Die Adresse wird bereits verwendet
- W: Cannot start IPv4 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
- W: Cannot start IPv6 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect

[skyper]

Replying to naoliv:

Download object w233056719.
Select it and revert changeset 36536612, with "Revert selection only"
When asked to download objects outside the current dataset, say Yes.

This work for me with reverter (36011)

Now with the same object selected choose "Revert selection and restore deleted objects".
The object is properly restored to its previous version but with one detail: every other deleted node is also restored, even the ones not related with this object.

This now leads to an exception: #22520