Modify ↓

Opened 7 years ago

Closed 7 years ago

#12354 closed enhancement (fixed)

[Patch] OsmPrimitiveKeyHandlingTest clean up

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.02
Component: Core Version:
Keywords: Cc:

Description

Cleaned up that test a bit and added some more tests (like also testing node.getKeys())

  • assertSame should not be used for primitives. In fact, it only works because the (normal) JVM caches Integer objects but assertSame(1000,1000) returns false.
  • assertEquals expects the first parameter to be the expected value.

Attachments (1)

patch-osm-primitive-key-test.patch​ (5.6 KB) - added by michael2402 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by michael2402

Attachment: patch-osm-primitive-key-test.patch​ added

comment:1 Changed 7 years ago by Don-vip

Keywords: jquery removed
Milestone: → 16.02

comment:2 Changed 7 years ago by Don-vip

Resolution: → fixed
Status: new → closed

In 9459/josm:

fix #12354 - OsmPrimitiveKeyHandlingTest clean up (patch by michael2402)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.