Modify

Opened 4 years ago

Closed 4 years ago

#12286 closed enhancement (fixed)

display tags, which are set by presets with <key>

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 16.02
Component: Core Version:
Keywords: Cc:

Description

Sometimes it is useful to know which tags a preset sets, because it is not always obvious (especially with non english josm). Tags which are set by <key key="..." value="..." /> are totally hidden in the preset dialog. It would be nice if these tags are displayed maybe similar to the following screenshot, however in grey like the keys of combos and texts are displayed.

Attachments (1)

keypreset.png (14.7 KB) - added by Klumbumbus 4 years ago.

Download all attachments as: .zip

Change History (13)

Changed 4 years ago by Klumbumbus

Attachment: keypreset.png added

comment:1 Changed 4 years ago by simon04

Resolution: fixed
Status: newclosed

In 9360/josm:

fix #12286 - Preset dialog: display the related key in a tooltip for every component

comment:2 Changed 4 years ago by simon04

Milestone: 16.02

comment:3 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

The enhancement is nice, however tags which are set by <key key="..." value="..." /> are still totally hidden.

comment:4 Changed 4 years ago by simon04

Right. Where should we put this information? As tooltip in the label ("Straßen/Straßen/Fahrradstraße" in the screenshot?).

comment:5 in reply to:  4 Changed 4 years ago by Klumbumbus

Replying to simon04:

As tooltip in the label ("Straßen/Straßen/Fahrradstraße" in the screenshot?).

Either that or like I showed in the screenshoot, the two lines below "Straßen/Straßen/Fahrradstraße" (but in grey, not in black). I would prefer the second solution, however this makes the window even bigger. Some presets already have really big preset windows.

comment:6 Changed 4 years ago by simon04

Ah, I overlooked this part in the "screenshot" – it looked so real :)

What I don't like from this suggestion is that many non-translated keys show up in this dialog, where everything else is translated.

comment:7 in reply to:  6 Changed 4 years ago by Klumbumbus

Replying to simon04:

Ah, I overlooked this part in the "screenshot" – it looked so real :)

It is a real screenshoot. I used <label> and the tagging presets tester plugin :)

What I don't like from this suggestion is that many non-translated keys show up in this dialog, where everything else is translated.

Well the grey "untranslated" keys in the combo and text boxes are already there now, which is good. However I understand what you mean and we can go for the tooltip solution.

(My thought was that you sometimes maybe expect another tag than the preset actually silently sets. When using the bunker preset do you expect amenity=bunker, building=bunker, building:type=bunker, military=bunker, man_made=bunker,...? With the tooltip solution this is still kind of hidden. But atleast you can easily look up.)

comment:8 in reply to:  6 ; Changed 4 years ago by Don-vip

Replying to simon04:

What I don't like from this suggestion is that many non-translated keys show up in this dialog, where everything else is translated.

+1 I'd vote for a tooltip somewhere. Maybe visible with a new icon, like an interrogation mark.

comment:9 in reply to:  8 ; Changed 4 years ago by Klumbumbus

Replying to Don-vip:

+1 I'd vote for a tooltip somewhere. Maybe visible with a new icon, like an interrogation mark.

Sounds good. Or maybe simply this one? https://josm.openstreetmap.de/browser/josm/trunk/images/dialogs/propertiesdialog.svg

comment:10 in reply to:  9 Changed 4 years ago by stoecker

Replying to Klumbumbus:

Replying to Don-vip:

+1 I'd vote for a tooltip somewhere. Maybe visible with a new icon, like an interrogation mark.

Sounds good. Or maybe simply this one? https://josm.openstreetmap.de/browser/josm/trunk/images/dialogs/propertiesdialog.svg

Sounds good to me. But keep the one-clicks in mind.

comment:12 Changed 4 years ago by simon04

Resolution: fixed
Status: reopenedclosed

In 9467/josm:

fix #12286 - Preset dialog: display the added tags due to <key> items

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.