Modify

Opened 4 years ago

Closed 4 years ago

#12278 closed enhancement (fixed)

[Patch] Fix checkstyle file names

Reported by: michael2402 Owned by: team
Priority: trivial Milestone: 16.01
Component: Core Version:
Keywords: checkstyle Cc:

Description

suppressions -> files needs to be a regexp.

No real problem...

Checkstyle was also complaining about that config file not having a new line at the end.

Attachments (1)

patch-fix-checkstyle-filename.patch (6.0 KB) - added by michael2402 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by michael2402

comment:1 Changed 4 years ago by Don-vip

How do you run checkstyle? I got no problem with Eclipse, Ant or Jenkins, I don't understand why it's a problem for your setup.

comment:2 Changed 4 years ago by michael2402

I run checkstyle using "ant checkstyle". And Eclipse runs it on every source file I edit.

The problem here is simply that people don't see that the file names are a regexp that just needs to be contained in the file path. So if anyone ever adds a class like "OsmEntities", that class is also excluded from checkstyle.

This might be intentional but we should at least make it clear that we are using regexp matching here by escaping the .

comment:3 Changed 4 years ago by Don-vip

Keywords: checkstyle added
Milestone: 16.01

comment:4 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 9297/josm:

fix #12278 - Fix checkstyle file names (patch by michael2402)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.