Modify

Opened 4 years ago

Closed 4 years ago

#12133 closed enhancement (fixed)

warn about name=fixme and its variations

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 15.12
Component: Core validator Version:
Keywords: Cc:

Description (last modified by Klumbumbus)

name=fixme, name=Fixme and name=FIXME are used 1214 times, see taginfo comparison

the count of all variations of the fixme word is even 1315, see http://overpass-turbo.eu/s/cSb

We should warn about this. Replacing it with fixme=name is not good, because the error can be detected by error tools even wthout this additional tag, see Key:fixme

Here is the test:

*[name][name=~/^(?i)fixme$/] {
  throwWarning: tr("Wrong usage of {0} tag. Remove {1}, because it is clear that the name is missing even without an additional tag.", "{0.key}", "{0.tag}");
  fixRemove: "name";
  assertMatch: "node name=fixme";
  assertMatch: "node name=Fixme";
  assertMatch: "node name=FIXME";
  assertNoMatch: "node name=valid name";
}

Attachments (0)

Change History (2)

comment:1 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 9088/josm:

fix #12133 - warn about name=fixme

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.