Warn user before closing JOSM with unsaved adjusted pictures

[skorbut]

If the user has moved one or several pictures without saving them and tries to close JOSM, the plugin should warn the user and give him the possibility to write changes to the files before closing JOSM.

[holgermappt]

Good idea. The other way to modify or set the image GPS position is to correlate with a GPX track. The JOSM default is to ignore such changes. A user who is used to that behavior might be annoyed by the additional warning. The warning could be an option that can be disabled in the preferences.

[skorbut]

Actually what I did and why I was writing the ticket was the following: I correlated a series of photos using a GPX track to prepare them for a (manual) upload to Mapillary. Because I noticed that the GPX track was off in some places, I began to adjust the photos' position there. I was working on my laptop in the train and had to leave in a hurry and semi-accidentally closed JOSM, what of course caused the adjustments to be thrown away.

I can understand that having a warning for dismissing correlated positions might annoy users. JOSM might ask them a first time and give a checkbox to disable this behaviour, or not ask them at all: Correlating pictures with a GPX track doesn't take much time, whereas manually adjusting the pictures does. So a warning only in this case would also do IMHO.

[holgermappt]

The warning was added in JOSM r9751 as unsaved changes dialog. That dialog is always shown if there are photos with modified GPS data. I don't think that dialog should have a ignore changes for this layer type checkbox.