Changes between Initial Version and Version 1 of Ticket #12016


Ignore:
Timestamp:
2015-10-28T08:34:07+01:00 (8 years ago)
Author:
rickmastfan67
Comment:

Simplified the steps to reproduce this above, as it still happens after the updated way was uploaded to the OSM database.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12016

    • Property Priority normal → major
    • Property Summary History dialog in rare cases shows a way was reversed when it wasn't after replacing the geometry of it. → History dialog in rare cases shows a way was reversed when it wasn't.

  • Ticket #12016 – Description

    initial v1  
    1 I just happened to run across this when repairing a highway interchange since it had been completely realigned and needed to be fixed in the OSM data.  I don't think this is caused by the 'utilsplugin2' plugin, but something that has gone wrong inside of the history display.
     1I just happened to run across this when repairing a highway interchange since it had been completely realigned and needed to be fixed in the OSM data.  I don't think this is caused by the 'utilsplugin2' plugin's "Replace Geometry", but something that has gone wrong inside of the history display.
    22
    33Steps to reproduce:
    4 1. Make sure you have the 'utilsplugin2' plugin installed.  If you don't, please install it first before going to Step 2.
    5 2. Open the attached file. (Please don't upload any results from this as I'm still working on fixing this area.)
    6 3. Select the two ways shown.
    7 4. Hit Ctrl+Shirt+G to replace the current stream's geometry with the untagged way's geometry.
    8 5. Once the replace geometry has been completed, hit 'Ctrl+H' to bring up the history for the way.
    9 6. Once the history window is open, go to the 'Nodes' view.
     41. Download one of the following ways into JOSM: https://www.openstreetmap.org/way/205003377 https://www.openstreetmap.org/way/205003306 https://www.openstreetmap.org/way/31705157 (all 3 exhibit this bug)
     52. Select the way you downloaded (let's use Way 205003377 as the example here), and then hit 'Ctrl+H' to bring up the history for the way.
     63. Once the history window is open, go to the 'Nodes' view.
     74. Start off by comparing V1 w/ V1, and notice that Node 2149795917 is the first node, and 2149795972 is the last node.
     85. Now, compare V1 w/ V2.
    109
    1110What happens:
    12 The way is displayed as being reversed when it wasn't.
     11Way 205003377 is displayed as being reversed between versions 1 & 2 with Node 2149795917 still being the first node, and 2149795972 the last node of the way.
    1312
    1413What should happen:
    15 The way should be displayed as going the same direction in the history between both versions since the start/end nodes weren't changed and the new way was drawn in the same direction.
     14Way 205003377 shouldn't be displayed as being reversed between versions 1 & 2 since the start/end nodes are still exactly the same for the way, and so is the direction.
    1615
    17 It can be confirmed that the 'Node 2149795917' is still the first node in the way if you hit 'Ctrl+I' to bring up the 'Advanced Info' window for the way.  Thus, I have no idea why the history window is spazzing out here showing the incorrect info.
     16If you view the history for any of the ways listed above and look at the version right before my edits, you can see that the same nodes are the starting/ending nodes in each version.  No idea why JOSM is doing this.  Will attempt to find a possible regression window if there is one.
    1817
    1918{{{
    2019Repository Root: http://josm.openstreetmap.de/svn
    21 Build-Date: 2015-10-26 23:56:23
    22 Last Changed Author: Don-vip
    23 Revision: 8951
     20Build-Date: 2015-10-28 02:32:10
     21Last Changed Author: simon04
     22Revision: 8964
    2423Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
    2524Relative URL: ^/trunk
    2625URL: http://josm.openstreetmap.de/svn/trunk
    27 Last Changed Date: 2015-10-26 14:28:49 +0100 (Mon, 26 Oct 2015)
    28 Last Changed Rev: 8951
     26Last Changed Date: 2015-10-27 23:40:20 +0100 (Tue, 27 Oct 2015)
     27Last Changed Rev: 8964
    2928
    30 Identification: JOSM/1.5 (8951 en) Windows 7 64-Bit
    31 Memory Usage: 373 MB / 1820 MB (134 MB allocated, but free)
     29Identification: JOSM/1.5 (8964 en) Windows 7 64-Bit
     30Memory Usage: 371 MB / 1820 MB (60 MB allocated, but free)
    3231Java version: 1.7.0_79, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
    3332Dataset consistency test: No problems found