Modify

Opened 4 years ago

Closed 4 years ago

#11952 closed enhancement (fixed)

Patch to add Keywords to josm{,-latest}.desktop + validation fixes

Reported by: sebastic Owned by: bastiK
Priority: normal Milestone: 15.10
Component: Ubuntu package Version:
Keywords: Linux desktop Cc:

Description (last modified by sebastic)

The lintian QA tool reports a desktop-entry-lacks-keywords-entry issue when desktop entries don't contain the Keywords key or when it does not contain any keywords not already present in the "Name" or "GenericName" entries as documented in the lintian tag description.

The attached patch adds the Keywords entry for both tested & latest, and also fixes the following issues reported by the desktop-file-validate utility:

linux/tested/usr/share/applications/josm.desktop: error: (will be fatal in the future): value "josm.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
linux/tested/usr/share/applications/josm.desktop: error: value "application/x-osm+xml;application/x-gpx+xml" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
linux/tested/usr/share/applications/josm.desktop: error: value "Education;Geoscience;Maps" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
linux/tested/usr/share/applications/josm.desktop: error: value "OpenStreetMap;OSM" for locale string list key "Keywords" in group "Desktop Entry" does not have a semicolon (';') as trailing character

linux/latest/usr/share/applications/josm-latest.desktop: error: (will be fatal in the future): value "josm-latest.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
linux/latest/usr/share/applications/josm-latest.desktop: error: value "application/x-osm+xml;application/x-gpx+xml" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
linux/latest/usr/share/applications/josm-latest.desktop: error: value "Education;Geoscience;Maps" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
linux/latest/usr/share/applications/josm-latest.desktop: error: value "OpenStreetMap;OSM" for locale string list key "Keywords" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Attachments (1)

josm-desktop-keywords+validation-fixes.patch (1.5 KB) - added by sebastic 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by sebastic

comment:1 Changed 4 years ago by sebastic

Description: modified (diff)
Summary: Patch to add Keywords to josm{,-latest}.desktopPatch to add Keywords to josm{,-latest}.desktop + validation fixes

comment:2 Changed 4 years ago by Don-vip

Keywords: Linux desktop added
Milestone: 15.10

comment:3 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 8841/josm:

fix #11952 - add Keywords to josm{,-latest}.desktop + validation fixes (patch by sebastic)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain bastiK.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.