Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11930 closed defect (fixed)

NPE in RasterFiltersPlugin.layerAdded during MissingRoads initialization

Reported by: anonymous Owned by: Nipel-Crumple
Priority: normal Milestone:
Component: Plugin rasterfilters Version:
Keywords: template_report github Cc: Daraxy

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. Start JOSM with the list of plugins.
  2. Used OSM to remote control an area with http://www.openstreetmap.org/edit?editor=remote&way=32136087#map=17/32.16245/-110.92363
  3. Dos window reports
    ...
    INFO: GET https://a.tile.openstreetmap.org/15/6153/13121.png -> 200
    INFO: RemoteControl received: GET /load_and_zoom?left=-110.92875467071532&top=32.16562281714171&right=-110.91851248016357&bottom=32.15928310639234&select=way321
    36087 HTTP/1.1
    INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9287547,32.1592831,-110.9185125,32.1656228
    INFO: Silent shortcut conflict: 'reltoolbox:addremove' moved by 'view:zoominter' to 'Ctrl+Alt+F3'.
    MAP FRAME INIT
    INFO: Silent shortcut conflict: 'conflation:replace' moved by 'reltoolbox:find' to 'Ctrl+Alt+F4'.
    INFO: Silent shortcut conflict: 'subwindow:junctionchecker' moved by 'tools:extnode' to 'Ctrl+Alt+F5'.
    ERROR: org.openstreetmap.josm.plugins.PluginException: An error occurred in plugin missingRoads. Cause: java.lang.reflect.InvocationTargetException. Cause: java.lang.NullPointerException
    org.openstreetmap.josm.plugins.PluginException: An error occurred in plugin missingRoads
    
  4. I keep the Plugin during the "Do you want to remove the plugin?" question.
  5. The same remote control URL produces
    INFO: RemoteControl received: GET /load_and_zoom?left=-110.9319733215332&top=32.16562281714171&right=-110.9152938293457&bottom=32.15928310639234&select=way32136087 HTTP/1.1
    INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9319733,32.1592831,-110.9152938,32.1656228
    Getting 50.9% of area, already have 87.6%, overlap 38.5%
    INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9152938,32.1585583,-110.9134634,32.1656228
    INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9338037,32.1565528,-110.9319733,32.1656228
    INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9319733,32.1565528,-110.9134634,32.1585583
    

What is the expected result?

INFO: RemoteControl received: GET /load_and_zoom?left=-110.9319733215332&top=32.16562281714171&right=-110.9152938293457&bottom=32.15928310639234&select=way32136087 HTTP/1.1
INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9319733,32.1592831,-110.9152938,32.1656228
Getting 50.9% of area, already have 87.6%, overlap 38.5%
INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9152938,32.1585583,-110.9134634,32.1656228
INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9338037,32.1565528,-110.9319733,32.1656228
INFO: GET https://api.openstreetmap.org/api/0.6/map?bbox=-110.9319733,32.1565528,-110.9134634,32.1585583

What happens instead?

Null pointer but the plugin still continues to work.

Please provide any additional information below. Attach a screenshot if possible.

Revision: 8800
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: simon04
Last Changed Date: 2015-09-27 22:11:06 +0200 (Sun, 27 Sep 2015)
Build-Date: 2015-09-28 01:32:03
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8800

Identification: JOSM/1.5 (8800 en) Windows 7 64-Bit
Memory Usage: 486 MB / 1230 MB (337 MB allocated, but free)
Java version: 1.8.0_31, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-XX:NumberOfGCLogFiles=10, -XX:GCLogFileSize=8K, -Djosm.pref=\gis\apps\josm, -Djosm.cache=\gis\data\josm_temp, -Djosm.userdata=\gis\apps\josm\data_files, -Djosm.home=\gis\apps\josm]
Dataset consistency test: No problems found

Plugins:
- ColorPlugin (1414145445)
- CommandLine (31241)
- Create_grid_of_ways (31241)
- DirectDownload (31241)
- DirectUpload (31241)
- DxfImport (UNKNOWN)
- FastDraw (31265)
- FixAddresses (31241)
- HouseNumberTaggingTool (31241)
- ImportImagePlugin (31241)
- Mapillary (31550)
- OpeningHoursEditor (31241)
- PicLayer (31241)
- RoadSigns (31241)
- ShapeTools (1000)
- alignways (31241)
- buildings_tools (31558)
- commons-imaging (31241)
- conflation (0.1.7)
- continuosDownload (1413902943)
- dataimport (31241)
- download_along (31241)
- editgpx (31241)
- ext_tools (31241)
- geotools (31126)
- graphview (31241)
- imageryadjust (31241)
- jna (31126)
- jts (31126)
- junctionchecking (31241)
- kendzi3d-jogl (41)
- lakewalker (31241)
- log4j (31231)
- mbtiles (v1.2)
- measurement (31289)
- missingRoads (31)
- namemanager (31241)
- opendata (31241)
- openvisible (31241)
- osmarender (31241)
- pbf (31241)
- pdfimport (31241)
- photo_geotagging (31241)
- photoadjust (31413)
- poly (31241)
- print (31329)
- proj4j (31353)
- public_transport (31241)
- public_transport_layer (31220)
- rasterfilters (31509)
- reltoolbox (31241)
- reverter (31241)
- routes (31241)
- routing (31241)
- tageditor (31576)
- tagging-preset-tester (31241)
- todo (29154)
- touchscreenhelper (31241)
- turnlanes (31241)
- turnrestrictions (31578)
- undelete (31241)
- utilsplugin2 (31463)
- videomapping (31241)
- waydownloader (31241)
- wikipedia (31241)

Last errors/warnings:
- E: org.openstreetmap.josm.plugins.PluginException: An error occurred in plugin missingRoads. Cause: java.lang.reflect.InvocationTargetException. Cause: java.lang.NullPointerException
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image ''
- E: Failed to locate image ''

org.openstreetmap.josm.plugins.PluginException: An error occurred in plugin missingRoads
	at org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:34)
	at org.openstreetmap.josm.Main.setMapFrame(Main.java:508)
	at org.openstreetmap.josm.Main.createMapFrame(Main.java:771)
	at org.openstreetmap.josm.Main.addLayer(Main.java:758)
	at org.openstreetmap.josm.Main.addLayer(Main.java:743)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$AbstractInternalTask.addNewLayerIfRequired(DownloadOsmTask.java:277)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$AbstractInternalTask.loadData(DownloadOsmTask.java:284)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$DownloadTask.finish(DownloadOsmTask.java:346)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable$1.run(PleaseWaitRunnable.java:101)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.do
Caused by: java.lang.NullPointerException
        at org.openstreetmap.josm.plugins.rasterfilters.RasterFiltersPlugin.layerAdded(RasterFiltersPlugin.java:100)
        at org.openstreetmap.josm.gui.MapView.fireLayerAdded(MapView.java:210)
        at org.openstreetmap.josm.gui.MapView.addLayer(MapView.java:427)
        at org.openstreetmap.josm.Main.addLayer(Main.java:761)
        at org.openstreetmap.josm.Main.addLayer(Main.java:743)
        at org.openstreetmap.josm.Main.addLayer(Main.java:730)
        at org.openstreetmap.josm.plugins.missinggeo.MissingGeometryPlugin.addLayer(Unknown Source)
        at org.openstreetmap.josm.plugins.missinggeo.MissingGeometryPlugin.mapFrameInitialized(Unknown Source)
        ... 74 more
INFO: Silent shortcut conflict: 'subwindow:todo' moved by 'tool:revert' to 'Ctrl+Alt+F6'.
Getting 37.9% of area, already have 62.1%, overlap 0.0%

Attachments (0)

Change History (13)

comment:1 by Klumbumbus, 10 years ago

Ticket #11927 has been marked as a duplicate of this ticket.

comment:2 by Klumbumbus, 10 years ago

Cc: Daraxy added
Component: CorePlugin

comment:3 by Don-vip, 10 years ago

Component: PluginPlugin MissingRoads

comment:4 by Don-vip, 10 years ago

Keywords: github added

comment:5 by Don-vip, 10 years ago

Description: modified (diff)

comment:6 by Don-vip, 10 years ago

Component: Plugin MissingRoadsPlugin rasterfilters
Owner: changed from team to Nipel-Crumple

comment:7 by Don-vip, 10 years ago

Summary: A mix of plugins along with the new Missing Roads plugin produces a null pointer exception -- The bug/ticket may or may not be yours.NPE in RasterFiltersPlugin.layerAdded during MissingRoads initialization

comment:8 by Don-vip, 10 years ago

@Nipel-Crumple: can you please have a look? I have clarified the ticket.

comment:9 by Nipel-Crumple, 10 years ago

I'm sorry for delay, I will try to fix it tomorrow.

Thank you very much!

in reply to:  7 comment:10 by Nipel-Crumple, 10 years ago

Replying to Don-vip:
I have fixed it in revision [o31635:31636], feel free to test it!

Thanks a lot!

Last edited 10 years ago by Don-vip (previous) (diff)

comment:11 by Don-vip, 10 years ago

Resolution: fixed
Status: newclosed

comment:12 by Don-vip, 10 years ago

thanks!

comment:13 by Don-vip, 10 years ago

Ticket #11951 has been marked as a duplicate of this ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Nipel-Crumple.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.