Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11846 closed defect (fixed)

Ignoring "Whole group" for MapCSS Validator test "street name contains ss" is not persistent.

Reported by: mdk Owned by: team
Priority: normal Milestone: 15.09
Component: Core validator Version: latest
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Download an area in Switzerland with a street name containing "Strasse" (common writing in CH).
  2. Run Validator
  3. Select "Other" - "street name contains ss" group
  4. "Ignore" - "Whole group"
  5. Restart JOSM
  6. Download same area (see 1.)
  7. Run Validator again

What is the expected result?

No "street name contains ss" results.

What happens instead?

The same "street name contains ss" results as from the first validator run.

Please provide any additional information below. Attach a screenshot if possible.

You can repeat the "Ignore" - "Whole group" several times.
If you look into "ignorederrors" file, you find for each ignore operation a line like:

3000_*[name'REGEX'(?i).*Strasse.*]::org.openstreetmap.josm.gui.mappaint.mapcss.Subpart$StringSubpart@1717f5a
3000_*[name'REGEX'(?i).*Strasse.*]::org.openstreetmap.josm.gui.mappaint.mapcss.Subpart$StringSubpart@c0d5a7
...

But I think the rule identifier should be constant ;-)

In Switzerland the "ß" character is not "known" and all street names use officially "ss" instead. Instead we would need a local validator test for "street name contains ß", but local validator rules are covered by another ticket as far as I remember, but I didn't found it yet.

Revision: 8737
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: wiktorn
Last Changed Date: 2015-09-08 21:50:08 +0200 (Tue, 08 Sep 2015)
Build-Date: 2015-09-09 01:32:25
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8737

Identification: JOSM/1.5 (8737 en) Linux Ubuntu 15.04
Memory Usage: 178 MB / 878 MB (65 MB allocated, but free)
Java version: 1.8.0_45-internal, Oracle Corporation, OpenJDK Server VM
VM arguments: [-javaagent:/usr/share/java/jayatanaag.jar, -Djosm.restart=true, -Djosm.home=/home/michael/.josm-latest, -Djava.net.useSystemProxies=true]

Plugins:
- ColumbusCSV (31241)
- FastDraw (31265)
- HouseNumberTaggingTool (31241)
- OpeningHoursEditor (31241)
- RoadSigns (31241)
- SimplifyArea (31241)
- buildings_tools (31361)
- contourmerge (1013)
- imagery-xml-bounds (31530)
- imagery_offset_db (31241)
- pbf (31241)
- poly (31241)
- public_transport (31241)
- reltoolbox (31241)
- reverter (31241)
- terracer (31241)
- turnrestrictions (31241)
- utilsplugin2 (31463)

Last errors/warnings:
- E: Failed to locate image 'maxspeed_icon.svg'
- W: Mappaint style "standard" (Maxspeed) icon "maxspeed_icon.svg" not found.

Attachments (0)

Change History (2)

comment:1 Changed 4 years ago by simon04

Resolution: fixed
Status: newclosed

In 8741/josm:

fix #11846 - MapCSS validator: make ignoring "Whole group" work again

comment:2 Changed 4 years ago by simon04

Milestone: 15.09

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.