Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11837 closed enhancement (fixed)

Advanced key:layer checking in the validator

Reported by: RicoZ Owned by: Klumbumbus
Priority: normal Milestone: 15.09
Component: Core validator Version:
Keywords: Cc:

Description

Recently I came across a bridge with layer=-1 across a river with (implicit) layer=0. Surprisingly Mapnik and many other renderers draw it "correctly" - bridge above water despite obviously wrong layer. The JOSM validator does not produce any warning in this situation.

This may serve as an example, version 5 of the way if someone fixes it:
http://www.openstreetmap.org/way/28590490#map=19/45.86651/10.93736&layers=D

To detect this kind of error it could be necessary to model the vertical stacking by key:layer and compare that to the vertical stacking resulting from the algorithm described here:

http://wiki.openstreetmap.org/wiki/Key:layer#Data_consumers

Attachments (1)

example-error.osm.gz (20.7 KB) - added by RicoZ 4 years ago.
example error

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by Klumbumbus

Component: CoreCore validator

Changed 4 years ago by RicoZ

Attachment: example-error.osm.gz added

example error

comment:2 Changed 4 years ago by RicoZ

attached example as I intend to fix the error in the OSM database soon.

While tweaking ​http://wiki.openstreetmap.org/wiki/Key:layer#Data_consumers I came to the conclusion that a test for

(bridge!=no && layer<0 && location!=underground && indoor!=yes)

should be sufficient to catch this situation without false positives (or extremely few of them at worst).

comment:3 Changed 4 years ago by Klumbumbus

Milestone: 15.09
Owner: changed from team to Klumbumbus
Status: newassigned

comment:4 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: assignedclosed

In 8754/josm:

fix #11837 - add validator warning Suspicious tag/value combination: bridge|tunnel and layer<0|layer>0

comment:5 Changed 4 years ago by Klumbumbus

In 8761/josm:

see #11837 - improve validator warning text

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.