Add render support for highway=cycleway + foot=designated

[cmeeren@…]

What steps will reproduce the problem?

1. Add a way with tags highway=cycleway and foot=designated

What is the expected result?

It should be both purple and green (dashed), just like with highway=cycleway + foot=yes

What happens instead?

It is only purple, indicating a cycleway only

Please provide any additional information below. Attach a screenshot if possible.

Revision: 8491
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2015-06-16 23:27:08 +0200 (Tue, 16 Jun 2015)
Build-Date: 2015-06-16 21:45:58
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8491

Identification: JOSM/1.5 (8491 en) Windows 7 64-Bit
Memory Usage: 247 MB / 247 MB (24 MB allocated, but free)
Java version: 1.8.0_51, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files (x86)\Java\jre1.8.0_51\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Users\Christer\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-23a0e964, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=8352, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAC1Eam5scC5hcHBsaWNhdGlvbi5ocmVmPWh0dHBzOi8vam9zbS5vcGVuc3RyZWV0bWFwLmRlL2Rvd25sb2FkL2pvc20uam5scAA=]
Dataset consistency test: No problems found

Plugins:
- turnrestrictions (31241)
- utilsplugin2 (31241)

Last errors/warnings:
- W: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketTimeoutException: connect timed out
- W: JOSM expected to find primitive [way 364973330] in dataset but it is not there. Please report this at https://josm.openstreetmap.de. This is not a critical error, it should be safe to continue in your work.
- E: java.lang.Exception
- W: Unable to remove primitives from TestError [tester=org.openstreetmap.josm.data.validation.tests.UnconnectedWays$UnconnectedHighways@d791c68c, code=1301, message=Way end node near other highway]
- W: Unable to remove primitives from TestError [tester=org.openstreetmap.josm.data.validation.tests.UnconnectedWays$UnconnectedHighways@d791c68c, code=1301, message=Way end node near other highway]

[anonymous]

I think it's not needed to modify rendering because the highway=path is the correct for this. I don't like the path, although we don't have a better alternative.
​https://wiki.openstreetmap.org/wiki/Tag:highway=path

(Just a sidenote. What about highway=footway + bicycle=designated? Use three tagging scheme for the exact same thing? Not a good idea.)

[mkoniecz]

What about highway=footway + bicycle=designated

JOSM validator: suspicious tag combination - highway=footway together with bicycle=designated (1)

Though less cryptic validator warning ("use highway=path + foot=designated + bicycle=designated instead of highway=footway for combined footway and cycleway") may be useful.

[anonymous]

Replying to mkoniecz:

JOSM validator: suspicious tag combination - highway=footway together with bicycle=designated (1)

Oh really, I didn't check this one. Interesting that highway=footway + bicycle=designated is suspicious combination but, highway=cycleway + foot=designated is not.

[mkoniecz]

Oh really, I didn't check this one. Interesting that highway=footway + bicycle=designated is suspicious combination but, highway=cycleway + foot=designated is not.

It may change with https://josm.openstreetmap.de/ticket/17542#comment:4

[anonymous]

Replying to mkoniecz:

It may change with https://josm.openstreetmap.de/ticket/17542#comment:4

I'm the reporter of that ticket, and this anon user as well :)

[mkoniecz]

Is still necessary to implement rendering for that?

Validator now complains about highway=cycleway + foot=designated and recommends switching to highway=path

foot=designated + bicycle=designated + highway=path has rendering support.

What more would be useful? Autofix move to foot=designated + bicycle=designated + highway=path should be suggested in a separate ticket if that is a good idea (feel free to ping me for a patch if that change would be a good idea).

[Don-vip]

Replying to anonyme:

I'm the reporter of that ticket, and this anon user as well :)

If you plan to contribute to JOSM tickets, can you please create an account? This makes the life easier for everyone. Thanks.

[Klumbumbus]

As the validation rule was removed again in r15248 and highway=cycleway + foot=designated or highway=footway + bicycle=designated seems to be the preferred method by some users/in some countries rendering should be adapted now too, see also https://josm.openstreetmap.de/ticket/17901#comment:5

[Klumbumbus]

In 15257/josm:

see #17901, fix #11780 - add preset and rendering support for highway=cycleway + foot=designated and highway=footway + bicycle=designated schema