#11696 closed enhancement (fixed)
[Patch] Option to prevent translation of values in presets.
| Reported by: | StephaneP | Owned by: | simon04 |
|---|---|---|---|
| Priority: | normal | Milestone: | 15.10 |
| Component: | Internal preset | Version: | |
| Keywords: | translation; collection_time | Cc: | Klumbumbus, stoecker |
Description
Hello !
With Josm sets in french, the preset for post_box contains a menu for the collection_time tag. But all the examples for the value are translated in french :
Lun-Ven instead of Mo-Fr
Attachments (1)
Change History (16)
comment:1 Changed 8 years ago by
| Owner: | changed from team to StephaneP |
|---|---|
| Status: | new → needinfo |
comment:2 Changed 8 years ago by
I thought that I made a mistake, but no.
If you choose one of the examples and don't touch it, the preset put the right english value :
I select "Lu-Ve 17:30; Sa 12:00"
the value become "Mo-Fr 17:30; Sa 12:00"
But if you select one example, then change something (you adapt the hours), the preset keep the translated value.
I select "Lu-Ve 17:30; Sa 12:00"
I change it to "Lu-Ve 17:30; Sa 09:00"
the value stays to "Lu-Ve 17:30; Sa 09:00"
comment:3 Changed 8 years ago by
| Summary: | Preset post_box : collection_time translated → Option to prevent translation of values in presets. |
|---|---|
| Type: | defect → enhancement |
Yes, It's not a good idea to use translation for presets where values are usually changed. But we currently have no possibility to prevent translation. Short-term-fix: Change french translation (see Translations). You can do this yourself.
Long-term-solution. Add possibility to prevent translation for some data fields with high probability of errors.
comment:4 Changed 8 years ago by
| Cc: | Klumbumbus added |
|---|
comment:6 Changed 8 years ago by
| Owner: | changed from StephaneP to team |
|---|---|
| Status: | needinfo → new |
Changed 8 years ago by
| Attachment: | 11696.patch added |
|---|
comment:7 Changed 8 years ago by
| Milestone: | → 15.10 |
|---|---|
| Owner: | changed from team to simon04 |
| Summary: | Option to prevent translation of values in presets. → [Patch] Option to prevent translation of values in presets. |
Patch attached. i18n/convpreset.pl needs to be adapted not not extract those values for translation.
comment:8 Changed 8 years ago by
| Cc: | stoecker added |
|---|
That's the case for most of JOSM's presets. JOSM automatically handles this and adds the untranslated text. That would only be an error, when the final tags contain translated texts. Do they?