highway=motorway not rendered with direction arrows

[naoliv]

I was trying to debug this routing problem in JOSM:

And I really couldn't find anything wrong.

Then, cliking at the highway segments I saw that they didn't any oneway tag.
Since highway=motorway implies oneway=yes (this is what we have in ​http://wiki.openstreetmap.org/wiki/Tag:highway%3Dmotorway and it's also how the routing programs use it), JOSM should draw the direction arrows on highway=motorway with oneway!=no (different from no)

As it's now we have a highway=motorway without oneway drawn exactly like a highway=motorway + oneway=no

JOSM

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-06-22 11:23:21
Last Changed Author: Don-vip
Revision: 8520
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-06-22 13:20:28 +0200 (Mon, 22 Jun 2015)
Last Changed Rev: 8520

Identification: JOSM/1.5 (8520 pt_BR) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 247 MB / 4029 MB (148 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u79-2.5.5-1
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

[Klumbumbus]

The same wiki page also suggests to add oneway=yes and says that the situation is country specific. To make it clear a motorway should always have a oneway tag. 99,21% already have a oneway tag ​http://taginfo.openstreetmap.org/tags/?key=highway&value=motorway#combinations. So, I'm going to add a warning for "motorway without oneway" (see #11564)

[naoliv]

Right, but then we have an implicity oneway=yes for highway=motorway_link (including the direction arrows by default, even without oneway=yes).
It seems a little incoherent to have two distinct forms to represent the same thing (motorway and motorway_link aren't, in general, that different).

[Klumbumbus]

Yes I think we should remove the arrows on motorway_link without oneway=* as a lot of motorway_links are not oneway.

[Klumbumbus]

In 8579/josm:

fix #11600 see #11393 - don't assume oneway=yes without oneway on highway=motorway_link

[Klumbumbus]

In 8580/josm:

see #11600 see #11393 - try to fix r8579

[Don-vip]

Replying to Klumbumbus:

a lot of motorway_links are not oneway.

Reference? I can't think right now of a motorway link not being a oneway. I' not sure to agree with this commit.

[Klumbumbus]

Replying to Don-vip:

Replying to Klumbumbus:

a lot of motorway_links are not oneway.

Reference? I can't think right now of a motorway link not being a oneway. I' not sure to agree with this commit.

​http://www.openstreetmap.org/#map=17/51.00091/13.20212
​http://www.openstreetmap.org/#map=17/50.90889/12.97712
These are typical motorway junctions in germany. There is no physical barrier between the lanes for the different directions, so it is one osm way (with oneway=no).

There are 17438 motorway_links with oneway=no, see ​http://overpass-turbo.eu/s/aj2

[Don-vip]

OK. But I don't think this is the most common situation. At least in France it's the opposite, and there are 471167 motorway_links with oneway=yes, see ​http://taginfo.openstreetmap.org/tags/highway=motorway_link#combinations (that's 94% of all motorway_links). Can you please revert this change?

[naoliv]

97.52% of the highway=motorway also have oneway=yes
Even thought the wiki says that tagging/implying oneway changes and is country specific sometimes, I never saw any consumer assuming that a highway=motorway is oneway=no when oneway isn't present.
Also, if I am not wrong, there was a time that JOSM drew it with oneway arrows.

Since now we have a warning when motorway and motorway_link don't have oneway, couldn't we keep drawing both with a direction arrow by default?

[Klumbumbus]

To me it is more logic if all highways are by default displayed like oneway=no. Even if the relative number of highway_motorway_link + oneway=no is low (3.5%) the absoulte number is pretty high (17.438) and implying oneway=yes, if oneway is not tagged, would be wrong for these 17438 cases.

However it is ok for me revert this change. But if we revert, we should also add oneway arrows on highway=motorway and lower the new "motorway|motorway_link without oneway warning" to info level. Otherwise it is inconsistent.

[Don-vip]

Replying to Klumbumbus:

But if we revert, we should also add oneway arrows on highway=motorway and lower the new "motorway|motorway_link without oneway warning" to info level. Otherwise it is inconsistent.

Absolutely. I thought it was already the case.

[Klumbumbus]

In 8591/josm:

fix #11600 see #11393 - (re)add default direction arrows for highway=motorway(_link); lower missing oneway tag to info level

[Klumbumbus]

In 8594/josm:

see #11600 see #11393 - fix r8591

[Don-vip]

Milestone renamed