TMS regression: can not load tiles from file://

[akks]

On the forum some people complained that they have to use r8159 because newer version does not support ​file:// in TMS urls (they have some custom downloaded tiles, I hope from allowed sources).

The error look like

ПРЕДУПРЕЖДЕНИЕ: java.lang.ClassCastException: sun.net.www.protocol.file.FileURLC
onnection cannot be cast to java.net.HttpURLConnection
ПРЕДУПРЕЖДЕНИЕ: JCS - Silent failure during download: file:/k:/SASPlanet/cache_g
mt/pskov/z14/4962/9558.png
ПРЕДУПРЕЖДЕНИЕ: JCS - Silent failure during download: file:/k:/SASPlanet/cache_g
mt/pskov/z14/4963/9558.png
ПРЕДУПРЕЖДЕНИЕ: JCS - Silent failure during download: file:/k:/SASPlanet/cache_g
mt/pskov/z14/4962/9559.png
ПРЕДУПРЕЖДЕНИЕ: JCS - Silent failure during download: file:/k:/SASPlanet/cache_g
mt/pskov/z14/4963/9559.png
java.lang.ClassCastException: sun.net.www.protocol.file.FileURLConnection cannot
be cast to java.net.HttpURLConnection
        at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.getURLConnec
tion(JCSCachedTileLoaderJob.java:426)
        at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.loadObject(J
CSCachedTileLoaderJob.java:331)
        at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.run(JCSCache
dTileLoaderJob.java:251)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)
java.lang.ClassCastException: sun.net.www.protocol.file.FileURLConnection cannot
be cast to java.net.HttpURLConnection
        at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.getURLConnec
tion(JCSCachedTileLoaderJob.java:426)
        at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.loadObject(J
CSCachedTileLoaderJob.java:331)
        at org.openstreetmap.josm.data.cache.JCSCachedTileLoaderJob.run(JCSCache
dTileLoaderJob.java:251)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)

Using ImageryCache plugin with old-style http loader solved the problem.

I have created some patch but it is better to be checked by specialist.
HTTP caching ticked may be related: https://josm.openstreetmap.de/ticket/10139

Compiled .jar with the patch: ​https://dl.dropboxusercontent.com/u/63393258/josm-custom-nonhttp-cache.jar

[akks]

(sorry, the first patch was unfinished)

[wiktorn]

In 8485/josm:

Addresses: #11548 - do not assume, that we work with HTTP based connection for fetching from remote resources

[wiktorn]

Thanks for the patch - I applied just slightly modifying it. But I leave this ticket open, as for next release, I'd like to approach this problem a bit differently and revert this changes. I can't do this right now, as it depends on changes, that are not yet in main tree.

[Don-vip]

skip milestone 15.06

[wiktorn]

In 8602/josm:

Properly handle file based tile sources.

• move getThreadFactory(String name) to Utils class, so it's easily usable across JOSM
• rollback changes in [8485]
• detect that we are working with filesystem TileSource in AbstractTileSourceLayer and if so, do not use JCS as caching mechanism, as tiles are already local
• change return value of getTileSourceInfo in AbstractTileSourceLayer to AbstractTMSTileSource, as this is anyway - lowest we can work with
• add test data for testing file base tile sources

closes: #11548

[Don-vip]

Milestone renamed