Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11533 closed defect (fixed)

modifying a just created note causes IllegalArgumentException

Reported by: malenki Owned by: team
Priority: major Milestone: 15.05
Component: Core notes Version:
Keywords: Cc:

Description (last modified by Don-vip)

How to reproduce:

  • create a new note
  • upload the new note
  • modify (add a comment or solve) the note

Result: as soon as you click Comment or Close note JOSM segfaults
Expected result: Modifying the note w/o problems
Additionally: When downloading notes of the area, the (not) modified note shows up a second time in the Notes window (see screenshot).

Screenshot of twice the same Notes in Notes window

Tested with r8471, r8339 with a blank ~/.josm

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-06-07 01:32:07
Last Changed Author: Don-vip
Revision: 8471
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-06-07 02:38:12 +0200 (Sun, 07 Jun 2015)
Last Changed Rev: 8471

Identification: JOSM/1.5 (8471 en) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 430 MB / 2222 MB (137 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u79-2.5.5-1
VM arguments: [-Dsun.java2d.opengl=false]


Last errors/warnings:
- E: java.lang.IllegalArgumentException: Note to close must be in layer

java.lang.IllegalArgumentException: Note to close must be in layer
	at org.openstreetmap.josm.data.osm.NoteData.closeNote(NoteData.java:238)
	at org.openstreetmap.josm.gui.dialogs.NotesDialog$CloseAction.actionPerformed(NotesDialog.java:332)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6516)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3312)
	at java.awt.Component.processEvent(Component.java:6281)
	at java.awt.Container.processEvent(Container.java:2229)
	at java.awt.Component.dispatchEventImpl(Component.java:4872)
	at java.awt.Container.dispatchEventImpl(Container.java:2287)
	at java.awt.Component.dispatchEvent(Component.java:4698)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
	at java.awt.Container.dispatchEventImpl(Container.java:2273)
	at java.awt.Window.dispatchEventImpl(Window.java:2719)
	at java.awt.Component.dispatchEvent(Component.java:4698)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:747)
	at java.awt.EventQueue.access$300(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:706)
	at java.awt.EventQueue$3.run(EventQueue.java:704)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.awt.EventQueue$4.run(EventQueue.java:720)
	at java.awt.EventQueue$4.run(EventQueue.java:718)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:717)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

Attachments (1)

2015-06-07_091505_scr.png (10.3 KB) - added by malenki 5 years ago.
Screenshot of twice the same Notes in Notes window

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by malenki

Attachment: 2015-06-07_091505_scr.png added

Screenshot of twice the same Notes in Notes window

comment:1 Changed 5 years ago by malenki

Component: CoreCore notes

comment:2 Changed 5 years ago by Don-vip

Description: modified (diff)

comment:3 Changed 5 years ago by Don-vip

Milestone: 15.05
Summary: modifying a just created note causes segfaultmodifying a just created note causes IllegalArgumentException

comment:4 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 8473/josm:

fix #11533 - proper use of Storage class in NoteData

comment:5 Changed 5 years ago by malenki

Thanks for the quick fix!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.