Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11479 closed defect (fixed)

[MapCSS] buildings not rendering in mapnik style

Reported by: wiktorn Owned by: team
Priority: normal Milestone: 15.05
Component: Core mappaint Version: tested
Keywords: mapcss regression Cc: bastiK, Klumbumbus

Description

Since @8339 buildings in mapnik style (https://github.com/bastik/mapcss-tools/tree/osm/mapnik2mapcss/osm-results) are not rendered correctly.

As far as I've checked the style hasn't changed for half a year. It looks like it is related to:
#11382 / [8297]

I've checked http://josm.openstreetmap.de/download/Archiv/josm-snapshot-8294.jar - and buildings are rendered properly.

With http://josm.openstreetmap.de/download/Archiv/josm-snapshot-8297.jar they are not.

Attachments (1)

bug-11479.patch (818 bytes) - added by michael2402 6 years ago.
This should fix it.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Klumbumbus

Cc: Klumbumbus added

comment:2 Changed 6 years ago by bastiK

This style should work, but does not in r8425:

way[building][railway!=station] {
    fill-color: #bca9a9;
}

comment:3 Changed 6 years ago by anonymous

I'll have a look at it tomorrow. My first idea would be that railway is considered to be a required key here (which it should not):

if (!Op.NEGATED_OPS.contains(keyValueCondition)) {

should be

if (!Op.NEGATED_OPS.contains(keyValueCondition.op)) {

comment:4 Changed 6 years ago by michael2402

I just tested it, the patch should fix the issue.

Changed 6 years ago by michael2402

Attachment: bug-11479.patch added

This should fix it.

comment:5 Changed 6 years ago by bastiK

Resolution: fixed
Status: newclosed

In 8432/josm:

fixed #11479 - buildings not rendering in mapnik style (patch by michael2402)

comment:6 Changed 6 years ago by Don-vip

Keywords: regression added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.