Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11445 closed enhancement (fixed)

[PATCH] Change POI icons: accommodation and food

Reported by: Yarl Owned by: Yarl
Priority: normal Milestone: 15.08
Component: Internal mappaint style Version:
Keywords: Cc: naoliv

Description

This patch changes icons of accommodation and food group to SVG icons taken from two GitHub repos: gravitystorm/openstreetmap-carto and nebulon42/osmic. Goal is to standardize icons across OSM, if it will be accepted, I will continue with other icons.

Attachments (7)

new-icons-food-and-accommodation.patch (10.9 KB) - added by Yarl 4 years ago.
patch
accommodation.zip (20.0 KB) - added by Yarl 4 years ago.
food.zip (14.4 KB) - added by Yarl 4 years ago.
iconcomp.png (276.9 KB) - added by Klumbumbus 4 years ago.
carto.png (14.5 KB) - added by Klumbumbus 4 years ago.
acc.png (3.1 KB) - added by Klumbumbus 4 years ago.
osmic-josm-shields.zip (108.1 KB) - added by nebulon42@… 4 years ago.
Osmic icons with white background 2px padding and 3px rounded corners

Download all attachments as: .zip

Change History (42)

Changed 4 years ago by Yarl

patch

Changed 4 years ago by Yarl

Attachment: accommodation.zip added

Changed 4 years ago by Yarl

Attachment: food.zip added

comment:1 Changed 4 years ago by Yarl

Zip files contains directories from path images/styles/standard. Some files were added, old ones removed.

comment:2 Changed 4 years ago by naoliv

Cc: naoliv added

comment:3 Changed 4 years ago by Yarl

Summary: [PATCH] Change POI icons[PATCH] Change POI icons: accommodation and food

comment:4 Changed 4 years ago by Klumbumbus

Whats the license of these icon? Are they identifiable at a size of 16px?

comment:5 Changed 4 years ago by Yarl

Both source repos are on CC0.
Icons looks OK for me, exactly like on osm.org.

comment:6 Changed 4 years ago by Klumbumbus

@team: any general comments to the unification of the icons with the mapnik style?

comment:7 Changed 4 years ago by bastiK

I like the suggested icons for accommodation, but would prefer the current JOSM icons for cafe, fast food, pub and biergarten.

comment:8 in reply to:  6 ; Changed 4 years ago by bastiK

Replying to Klumbumbus:

@team: any general comments to the unification of the icons with the mapnik style?

A map is not the same as an editor, so different design goal leads to different icon sets. Colorful icons make sense for JOSM as they are easier to recognize. On a map, you have to care about overall aesthetic look.

comment:9 in reply to:  8 Changed 4 years ago by Klumbumbus

Replying to bastiK:

A map is not the same as an editor, so different design goal leads to different icon sets. Colorful icons make sense for JOSM as they are easier to recognize. On a map, you have to care about overall aesthetic look.

Sounds reasonable. Some mapnik icons do not work anyway for JOSM like highway=traffic_signals, barrier=gate|lift_gate|bollard, amenity=bank|place_of_worship. I also think it is better to have more colorful icons instead of all shops purple. But I think we can replace some awful JOSM icons (like for optician). Also replacing some png by svg is a good thing.

comment:10 Changed 4 years ago by Yarl

Maybe I'll add my rationale for this change. Presonally (and I know it's not only my opinion) I prefer unification of icons because it's easier to find in menu and also on map. Frankly, sometimes it's hard to guess what is depicted on current JSOM icons - icons for osm.org are definitely better designed.

I can add some screenshots, but current latest code on repo gives me RuntimeException (Win 8 + NetBeans 8; build log here: http://pastebin.com/Y8LzgVxv)

Edit: most of the icons (all in this change) are SVG so different color for every menu is definitely possible).

Last edited 4 years ago by Yarl (previous) (diff)

Changed 4 years ago by Klumbumbus

Attachment: iconcomp.png added

comment:11 Changed 4 years ago by Klumbumbus

comparison screenshoot of current state at http://www.openstreetmap.org/#map=19/50.84661/12.93826


Last edited 4 years ago by Klumbumbus (previous) (diff)

comment:12 Changed 4 years ago by naoliv

Not so related with this ticket, but the butcher icon is missing in JOSM?

comment:13 in reply to:  12 Changed 4 years ago by Klumbumbus

Replying to naoliv:

Not so related with this ticket, but the butcher icon is missing in JOSM?

No, it is available.

Changed 4 years ago by Klumbumbus

Attachment: carto.png added

comment:14 Changed 4 years ago by Klumbumbus

Another thing is, that you often use aerial imagery background in JOSM and you need colorful icons to see them. Icons with only one color are often hard to see. So we would atleast need a white background for these icons.


comment:15 Changed 4 years ago by Klumbumbus

Milestone: 15.05

comment:16 Changed 4 years ago by Yarl

@Klumbumbus: yes, it looks you're right. Testing:

http://i.imgur.com/fYe5Pfa.png

comment:17 Changed 4 years ago by Klumbumbus

In 8434/josm:

see #11445 - new icon for amenity=restaurant

comment:18 Changed 4 years ago by Klumbumbus

Changed 4 years ago by Klumbumbus

Attachment: acc.png added

comment:19 Changed 4 years ago by Klumbumbus

Owner: changed from team to Yarl
Status: newneedinfo

Yarl, can you provide icons for hotel, motel and hostel with white background, where the blue part does not touch the border of the icon? Because with a simple white background attached this is not really an improvement to current state:


comment:20 in reply to:  19 ; Changed 4 years ago by Don-vip

Replying to Klumbumbus:

Yarl, can you provide icons for hotel, motel and hostel with white background

is it the only remaining thing to do? I'd like to close this ticket in this release :)

comment:21 in reply to:  20 Changed 4 years ago by Klumbumbus

Replying to Don-vip:

Replying to Klumbumbus:

Yarl, can you provide icons for hotel, motel and hostel with white background

is it the only remaining thing to do? I'd like to close this ticket in this release :)

Yes, but the important part is "where the blue part does not touch the border of the icon"

comment:22 Changed 4 years ago by Yarl

OK guys, tomorrow there is a bank holiday in Poland, so I'll be offline until end of week. You can wait or close this issue. I'll deliver icons next week.

comment:23 Changed 4 years ago by Don-vip

Milestone: 15.0515.06

we'll wait, no problem :)

comment:24 Changed 4 years ago by nebulon42@…

I created Osmic and most of the new icons in osm-carto. To customise the icons from Osmic you can use a script, it is possible to add shields, rounded corners, re-colour, adjust padding, re-size etc. Have a look at https://github.com/nebulon42/osmic/blob/master/tools/export.md. I'm happy to help, just let me know what you need.

comment:25 Changed 4 years ago by Don-vip

Milestone: 15.0615.07

skip milestone 15.06

Changed 4 years ago by nebulon42@…

Attachment: osmic-josm-shields.zip added

Osmic icons with white background 2px padding and 3px rounded corners

comment:26 Changed 4 years ago by nebulon42@…

I have added an archive with all icons that I made with a white background, 2px padding between icon and shield border and 3px rounded corners. This was generated with the following config file: https://github.com/nebulon42/osmic/blob/master/tools/josm-shields.yaml
If you need different parameters or the icons in different form let me know.

comment:27 Changed 4 years ago by Yarl

Thanks nebulon, here's how they look like on map. I used shield icons for map and icons with transparent backgroud for menu.

http://i.imgur.com/GIa4JNo.png

comment:28 Changed 4 years ago by nebulon42@…

Looks fine to me. Having all icons in the same (black/grey) colour would also be an option (better contrast on the map).

comment:29 Changed 4 years ago by bastiK

@Klumbumbus: What is the status?

comment:30 Changed 4 years ago by Klumbumbus

I will replace some icons when I have some time. Probably tomorrow.

comment:31 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: needinfoclosed

In 8592/josm:

fix #11445 - replace some icons, move old icons to josm nodist folder. source of new icons: https://github.com/nebulon42/osmic-josm-style/archive/master.zip, CC0

comment:32 Changed 4 years ago by Klumbumbus

see also [o31365]

comment:33 Changed 4 years ago by Klumbumbus

In 8593/josm:

see #11445 - move old icon to nodist folder

comment:34 Changed 4 years ago by Don-vip

Milestone: 15.0715.08

Milestone renamed

comment:35 Changed 4 years ago by Don-vip

Component: CoreInternal mappaint style

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Yarl.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.