[PATCH] Change POI icons: accommodation and food

[Yarl]

This patch changes icons of accommodation and food group to SVG icons taken from two GitHub repos: gravitystorm/openstreetmap-carto and nebulon42/osmic. Goal is to standardize icons across OSM, if it will be accepted, I will continue with other icons.

[Yarl]

patch

[Yarl]

Zip files contains directories from path images/styles/standard. Some files were added, old ones removed.

[Klumbumbus]

Whats the license of these icon? Are they identifiable at a size of 16px?

[Yarl]

Both source repos are on CC0.
Icons looks OK for me, exactly like on osm.org.

[Klumbumbus]

@team: any general comments to the unification of the icons with the mapnik style?

[bastiK]

I like the suggested icons for accommodation, but would prefer the current JOSM icons for cafe, fast food, pub and biergarten.

[bastiK]

Replying to Klumbumbus:

@team: any general comments to the unification of the icons with the mapnik style?

A map is not the same as an editor, so different design goal leads to different icon sets. Colorful icons make sense for JOSM as they are easier to recognize. On a map, you have to care about overall aesthetic look.

[Klumbumbus]

Replying to bastiK:

A map is not the same as an editor, so different design goal leads to different icon sets. Colorful icons make sense for JOSM as they are easier to recognize. On a map, you have to care about overall aesthetic look.

Sounds reasonable. Some mapnik icons do not work anyway for JOSM like highway=traffic_signals, barrier=gate|lift_gate|bollard, amenity=bank|place_of_worship. I also think it is better to have more colorful icons instead of all shops purple. But I think we can replace some awful JOSM icons (like for optician). Also replacing some png by svg is a good thing.

[Yarl]

Maybe I'll add my rationale for this change. Presonally (and I know it's not only my opinion) I prefer unification of icons because it's easier to find in menu and also on map. Frankly, sometimes it's hard to guess what is depicted on current JSOM icons - icons for osm.org are definitely better designed.

I can add some screenshots, but current latest code on repo gives me RuntimeException (Win 8 + NetBeans 8; build log here: ​http://pastebin.com/Y8LzgVxv)

Edit: most of the icons (all in this change) are SVG so different color for every menu is definitely possible).

[Klumbumbus]

comparison screenshoot of current state at ​http://www.openstreetmap.org/#map=19/50.84661/12.93826

[naoliv]

Not so related with this ticket, but the butcher icon is missing in JOSM?

[Klumbumbus]

Replying to naoliv:

Not so related with this ticket, but the butcher icon is missing in JOSM?

No, it is available.

[Klumbumbus]

Another thing is, that you often use aerial imagery background in JOSM and you need colorful icons to see them. Icons with only one color are often hard to see. So we would atleast need a white background for these icons.

[Yarl]

@Klumbumbus: yes, it looks you're right. Testing:

[Klumbumbus]

In 8434/josm:

see #11445 - new icon for amenity=restaurant

[Klumbumbus]

icon [o31162]

[Klumbumbus]

Yarl, can you provide icons for hotel, motel and hostel with white background, where the blue part does not touch the border of the icon? Because with a simple white background attached this is not really an improvement to current state:

[Don-vip]

Replying to Klumbumbus:

Yarl, can you provide icons for hotel, motel and hostel with white background

is it the only remaining thing to do? I'd like to close this ticket in this release :)

[Klumbumbus]

Replying to Don-vip:

Replying to Klumbumbus:

Yarl, can you provide icons for hotel, motel and hostel with white background

is it the only remaining thing to do? I'd like to close this ticket in this release :)

Yes, but the important part is "where the blue part does not touch the border of the icon"

[Yarl]

OK guys, tomorrow there is a bank holiday in Poland, so I'll be offline until end of week. You can wait or close this issue. I'll deliver icons next week.

[Don-vip]

we'll wait, no problem :)

[nebulon42@…]

I created Osmic and most of the new icons in osm-carto. To customise the icons from Osmic you can use a script, it is possible to add shields, rounded corners, re-colour, adjust padding, re-size etc. Have a look at ​https://github.com/nebulon42/osmic/blob/master/tools/export.md. I'm happy to help, just let me know what you need.

[Don-vip]

skip milestone 15.06

[nebulon42@…]

Osmic icons with white background 2px padding and 3px rounded corners

[nebulon42@…]

I have added an archive with all icons that I made with a white background, 2px padding between icon and shield border and 3px rounded corners. This was generated with the following config file: ​https://github.com/nebulon42/osmic/blob/master/tools/josm-shields.yaml
If you need different parameters or the icons in different form let me know.

[Yarl]

Thanks nebulon, here's how they look like on map. I used shield icons for map and icons with transparent backgroud for menu.

[nebulon42@…]

Looks fine to me. Having all icons in the same (black/grey) colour would also be an option (better contrast on the map).

[bastiK]

@Klumbumbus: What is the status?

[Klumbumbus]

I will replace some icons when I have some time. Probably tomorrow.

[Klumbumbus]

In 8592/josm:

fix #11445 - replace some icons, move old icons to josm nodist folder. source of new icons: ​https://github.com/nebulon42/osmic-josm-style/archive/master.zip, CC0

[Klumbumbus]

see also [o31365]

[Klumbumbus]

In 8593/josm:

see #11445 - move old icon to nodist folder

[Don-vip]

Milestone renamed