Modify

Opened 5 years ago

Closed 5 years ago

#11360 closed defect (fixed)

opening_hours validator can not fix all warnings by itself.

Reported by: ypid23 Owned by: team
Priority: normal Milestone: 15.04
Component: Core validator Version: latest
Keywords: opening_hours Cc:

Description

Steps to reproduce:

  1. Create node with opening_hours=Th-Su
  2. Run validation
  3. Click on "Fix"
  4. Goto 2 :)

Problem is that opening_hours.js oh.getWarnings() returns warnings but they can not be fixed automatically. The value "Th-Su" is just one example. There are more. I would recommend to compare the result of oh.prettifyValue() with the current value and if they are the same to disable the fix button of this warning.

See Bugreport against opening_hours.js: https://github.com/ypid/opening_hours.js/issues/78

Attachments (0)

Change History (2)

comment:1 Changed 5 years ago by Don-vip

Milestone: 15.04

comment:2 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 8242/josm:

fix #11360 - do not propose autofix for opening_hours with the same value as before

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.