Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11347 closed enhancement (fixed)

[PATCH] Add Marine Fuel Station Preset (for Marinas and Harbors).

Reported by: brycenesbitt Owned by: team
Priority: minor Milestone: 15.05
Component: Internal preset Version:
Keywords: Cc: Klumbumbus

Description

While they both sell the same type of gas, a Marine fuel station is not the same as Transport/Car/Fuel. For one, cars approaching them tend to fall into the water.

Marinas with fuel stations are commonly mapped.

Here's a preset.
Note there is a seamark tag that covers the same ground.

Attachments (2)

josm_patch_marine_fuel.diff (2.6 KB) - added by brycenesbitt 4 years ago.
waterway=fuel
josm_patch_fuel_stations.diff (3.9 KB) - added by brycenesbitt 4 years ago.
Version 2 of patch, with airplanes

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by brycenesbitt

Attachment: josm_patch_marine_fuel.diff added

waterway=fuel

Changed 4 years ago by brycenesbitt

Version 2 of patch, with airplanes

comment:1 Changed 4 years ago by brycenesbitt

I updated the patch. Might as well handle aviation gas at the same time, as it's got such different fuel types in the preset.

comment:2 Changed 4 years ago by stoecker

Milestone: 15.05

comment:3 Changed 4 years ago by Klumbumbus

Cc: Klumbumbus added

comment:4 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8402/josm:

fix #11347 - add waterway=fuel to preset and mappaint style (modified patch by brycenesbitt)

comment:5 Changed 4 years ago by rickmastfan67

Some work still needs to be done on this ticket. Just noticed the following errors pop up when I started the new 'latest', r8406, tonight.

ERROR: Failed to locate image 'styles/standard/nautical/nautical/marine_fuel.png'
WARNING: Could not get presets icon styles/standard/nautical/nautical/marine_fuel.png

Just thought you'd like to know about this so it can be fixed.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-05-21 01:31:17
Last Changed Author: Don-vip
Revision: 8406
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-05-21 02:19:24 +0200 (Thu, 21 May 2015)
Last Changed Rev: 8406

Identification: JOSM/1.5 (8406 en) Windows 7 64-Bit
Memory Usage: 355 MB / 1820 MB (245 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM

Plugins:
- ImageryCache (31083)
- OpeningHoursEditor (30962)
- buildings_tools (31120)
- measurement (30892)
- mirrored_download (30962)
- osmarender (30892)
- reverter (31120)
- turnrestrictions (31034)
- undelete (30892)
- utilsplugin2 (31120)

comment:6 Changed 4 years ago by rickmastfan67

Resolution: fixed
Status: closedreopened

comment:7 Changed 4 years ago by Klumbumbus

In 8407/josm:

see #11347 - fix typo

comment:8 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

Thanks.

comment:9 Changed 4 years ago by brycenesbitt

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.