[PATCH] Add "storage_tank" preset (100,000 uses in database)

[brycenesbitt]

I've missed having an easy preset for a tank.
With 100,000 uses in the database, man_made=storage_tank seems like a winner, here's a preset.
I reused an old icon, I think that's OK here.

The German tagging wiki page recommends building=yes, and I followed that convention here.

[skyper]

How about adding capacity=* and material=* ?

I would not set building=yes without an option to change manually. In my eyes, a "combo" with default set to "yes" would be better.

[mkoniecz]

I think that building=storage_tank would be much better for a storage tank.

[skyper]

How about the icon ? I fear that using the same icon for storage_tank and water_tower will disguise the differences.

@stoecker:
Thought, I did already comment around ten days ago. Did I really miss the submit button or was there a problem with the server/database ?

[stoecker]

Hello,

Thought, I did already comment around ten days ago. Did I really miss the submit button or was there a problem with the server/database ?

No database issues known to me. Everything exceptionally stable.

[brycenesbitt]

@skyper I agree "content=*" should be there.

Tag numbers indicate that "building" can be left off completely:
114 050 man_made=storage_tank
7,282 building=storage_tank
804 man_made=fuel_storage_tank
643 building=storage tank
260 building:type=storage_tank
159 man_made=storage_tank;tower
135 building=fluid_storage_tank
70 note man_made=storage_tank are not yet (2013-01-11) rendered

In rendering for osm-carto perhaps the icon needs to be different, but not in JOSM editing where the tag name is shown.

[brycenesbitt]

Rev 2 of this patch

[brycenesbitt]

OK, I can make it building=storage_tank.

[aceman]

I'm happy that storage_tank is being added. But why both man_made= and building=? Haven't the users decide on man_made via using it in majority?

[brycenesbitt]

@aceman I think it's largely a rendering hack. man_made=storage_tank is more semantic. But German mappers found that adding building=yes makes it render nice for areas, and documented that on the wiki.

"Don't tag for the rendering" might be a mantra among experienced users, but with osm-carto rendering lagging so far behind tagging behavior, it's not reality.

building=storage_tank + man_made=storage_tank seems a reasonable compromise.

[mkoniecz]

building=storage_tank in my opinion is not an incorrect tag to describe structures like ​http://en.wikipedia.org/wiki/Storage_tank#/media/File:Fuel_tank_gnangarra.jpg - therefore IMHO it is not a tagging for renderer.

It is widely accepted that storage tanks should be described as man_made=storage_tank - but it does not mean that using also building=storage_tank is incorrect

Using building tag is helpful for all data consumers, not only for default map style. It allows to check just for building key rather than looking for many key and key-value pairs what simplifies processing of osm data ([building] query is much better than say [building

man_made=storage_tank

man_made=water_tower

aeroway=terminal

(amenity=place_of_worship && !building=no) <many many many more>])).

[Klumbumbus]

In 8328/josm:

fix #11339 - add man_made=storage_tank to preset and mappaint style (modified patch by brycenesbitt; icon derived from gasometer.png)

[Klumbumbus]

In 8335/josm:

see #11339 - fix position of preset entry man_made=storage_tank

[skyper]

additional tags patch

[skyper]

Replying to skyper:

How about adding capacity=* and material=* ?

Please, find additional patch​ adding some more common tags. Not sure if building=* should be optional, though.

[brycenesbitt]

@skyper could you use ​http://wiki.openstreetmap.org/wiki/Key:building:material to avoid confusion with contents?

At this point I feel building should be mandatory. In the rare case (of an underground tank?) the mapper can just delete the extra tag.

[skyper]

patch with building:material

[skyper]

Replying to brycenesbitt:

@skyper could you use ​osmwiki:Key:building:material to avoid confusion with contents?

At this point I feel building should be mandatory. In the rare case (of an underground tank?) the mapper can just delete the extra tag.

Still not happy with building=* but not the right time to discuss. See optional patch version 2​.

[brycenesbitt]

If we're designing tagging (rather than providing presets for existing use) then we should also get open top vs. closed top into there.

[Klumbumbus]

If we skip (the useless value) capacity=unknown, then capacity is used only 22 times on man_made=storage_tank. (​http://overpass-turbo.eu/s/9pc). For man_made=water_tower water_tower:volume is used even more then capacity. capacity wiki page does not mention man_made=* It seems there is no clear established tagging scheme so far.

[Klumbumbus]

In 8386/josm:

see #11339 - adjust presets for man_made=storage_tank|gasometer|water_tower|bunker_silo amenity=bench

[Klumbumbus]

Replying to brycenesbitt:

If we're designing tagging (rather than providing presets for existing use)

The Guidelines at DevelopersGuide/DefaultPresets didn't change.