#11339 closed enhancement (fixed)
[PATCH] Add "storage_tank" preset (100,000 uses in database)
Reported by: | brycenesbitt | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 15.05 |
Component: | Internal preset | Version: | |
Keywords: | Cc: | Klumbumbus |
Description (last modified by )
I've missed having an easy preset for a tank.
With 100,000 uses in the database, man_made=storage_tank seems like a winner, here's a preset.
I reused an old icon, I think that's OK here.
The German tagging wiki page recommends building=yes, and I followed that convention here.
Attachments (4)
Change History (25)
by , 9 years ago
Attachment: | preset_storage_tank.diff added |
---|
comment:1 by , 9 years ago
Description: | modified (diff) |
---|
comment:2 by , 9 years ago
Milestone: | → 15.05 |
---|
follow-up: 15 comment:3 by , 9 years ago
comment:4 by , 9 years ago
I think that building=storage_tank would be much better for a storage tank.
follow-up: 6 comment:5 by , 9 years ago
How about the icon ? I fear that using the same icon for storage_tank and water_tower will disguise the differences.
@stoecker:
Thought, I did already comment around ten days ago. Did I really miss the submit button or was there a problem with the server/database ?
comment:6 by , 9 years ago
Hello,
Thought, I did already comment around ten days ago. Did I really miss the submit button or was there a problem with the server/database ?
No database issues known to me. Everything exceptionally stable.
comment:7 by , 9 years ago
@skyper I agree "content=*" should be there.
Tag numbers indicate that "building" can be left off completely:
114 050 man_made=storage_tank
7,282 building=storage_tank
804 man_made=fuel_storage_tank
643 building=storage tank
260 building:type=storage_tank
159 man_made=storage_tank;tower
135 building=fluid_storage_tank
70 note man_made=storage_tank are not yet (2013-01-11) rendered
In rendering for osm-carto perhaps the icon needs to be different, but not in JOSM editing where the tag name is shown.
comment:9 by , 9 years ago
Cc: | added |
---|
comment:10 by , 9 years ago
I'm happy that storage_tank is being added. But why both man_made= and building=? Haven't the users decide on man_made via using it in majority?
comment:11 by , 9 years ago
@aceman I think it's largely a rendering hack. man_made=storage_tank is more semantic. But German mappers found that adding building=yes makes it render nice for areas, and documented that on the wiki.
"Don't tag for the rendering" might be a mantra among experienced users, but with osm-carto rendering lagging so far behind tagging behavior, it's not reality.
building=storage_tank + man_made=storage_tank seems a reasonable compromise.
comment:12 by , 9 years ago
building=storage_tank in my opinion is not an incorrect tag to describe structures like http://en.wikipedia.org/wiki/Storage_tank#/media/File:Fuel_tank_gnangarra.jpg - therefore IMHO it is not a tagging for renderer.
It is widely accepted that storage tanks should be described as man_made=storage_tank - but it does not mean that using also building=storage_tank is incorrect
Using building tag is helpful for all data consumers, not only for default map style. It allows to check just for building key rather than looking for many key and key-value pairs what simplifies processing of osm data
[building]
query is much better than say
[building or man_made=storage_tank or man_made=water_tower or aeroway=terminal or (amenity=place_of_worship and building!=no) <many many many more>]
comment:15 by , 9 years ago
follow-up: 17 comment:16 by , 9 years ago
@skyper could you use http://wiki.openstreetmap.org/wiki/Key:building:material to avoid confusion with contents?
At this point I feel building should be mandatory. In the rare case (of an underground tank?) the mapper can just delete the extra tag.
comment:17 by , 9 years ago
Replying to brycenesbitt:
@skyper could you use osmwiki:Key:building:material to avoid confusion with contents?
At this point I feel building should be mandatory. In the rare case (of an underground tank?) the mapper can just delete the extra tag.
Still not happy with building=*
but not the right time to discuss. See optional patch version 2.
follow-up: 21 comment:18 by , 9 years ago
If we're designing tagging (rather than providing presets for existing use) then we should also get open top vs. closed top into there.
comment:19 by , 9 years ago
If we skip (the useless value) capacity=unknown
, then capacity
is used only 22 times on man_made=storage_tank
. (http://overpass-turbo.eu/s/9pc). For man_made=water_tower
water_tower:volume
is used even more then capacity
. capacity
wiki page does not mention man_made=*
It seems there is no clear established tagging scheme so far.
comment:21 by , 9 years ago
Replying to brycenesbitt:
If we're designing tagging (rather than providing presets for existing use)
The Guidelines at DevelopersGuide/DefaultPresets didn't change.
How about adding
capacity=*
andmaterial=*
?I would not set
building=yes
without an option to change manually. In my eyes, a "combo" with default set to "yes" would be better.