Modify

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#11339 closed enhancement (fixed)

[PATCH] Add "storage_tank" preset (100,000 uses in database)

Reported by: brycenesbitt Owned by: team
Priority: minor Milestone: 15.05
Component: Internal preset Version:
Keywords: Cc: Klumbumbus

Description (last modified by brycenesbitt)

I've missed having an easy preset for a tank.
With 100,000 uses in the database, man_made=storage_tank seems like a winner, here's a preset.
I reused an old icon, I think that's OK here.

The German tagging wiki page recommends building=yes, and I followed that convention here.

Attachments (4)

preset_storage_tank.diff (1.4 KB) - added by brycenesbitt 5 years ago.
josm_patch_storage_tank.diff (1.4 KB) - added by brycenesbitt 4 years ago.
Rev 2 of this patch
josm_11339_add.patch (3.5 KB) - added by skyper 4 years ago.
additional tags patch
josm_11339_addv2.patch (3.5 KB) - added by skyper 4 years ago.
patch with building:material

Download all attachments as: .zip

Change History (25)

Changed 5 years ago by brycenesbitt

Attachment: preset_storage_tank.diff added

comment:1 Changed 5 years ago by brycenesbitt

Description: modified (diff)

comment:2 Changed 4 years ago by stoecker

Milestone: 15.05

comment:3 Changed 4 years ago by skyper

How about adding capacity=* and material=* ?

I would not set building=yes without an option to change manually. In my eyes, a "combo" with default set to "yes" would be better.

comment:4 Changed 4 years ago by mkoniecz

I think that building=storage_tank would be much better for a storage tank.

Last edited 4 years ago by mkoniecz (previous) (diff)

comment:5 Changed 4 years ago by skyper

How about the icon ? I fear that using the same icon for storage_tank and water_tower will disguise the differences.

@stoecker:
Thought, I did already comment around ten days ago. Did I really miss the submit button or was there a problem with the server/database ?

comment:6 in reply to:  5 Changed 4 years ago by stoecker

Hello,

Thought, I did already comment around ten days ago. Did I really miss the submit button or was there a problem with the server/database ?

No database issues known to me. Everything exceptionally stable.

comment:7 Changed 4 years ago by brycenesbitt

@skyper I agree "content=*" should be there.

Tag numbers indicate that "building" can be left off completely:
114 050 man_made=storage_tank
7,282 building=storage_tank
804 man_made=fuel_storage_tank
643 building=storage tank
260 building:type=storage_tank
159 man_made=storage_tank;tower
135 building=fluid_storage_tank
70 note man_made=storage_tank are not yet (2013-01-11) rendered

In rendering for osm-carto perhaps the icon needs to be different, but not in JOSM editing where the tag name is shown.

Changed 4 years ago by brycenesbitt

Rev 2 of this patch

comment:8 Changed 4 years ago by brycenesbitt

OK, I can make it building=storage_tank.

comment:9 Changed 4 years ago by Klumbumbus

Cc: Klumbumbus added

comment:10 Changed 4 years ago by aceman

I'm happy that storage_tank is being added. But why both man_made= and building=? Haven't the users decide on man_made via using it in majority?

comment:11 Changed 4 years ago by brycenesbitt

@aceman I think it's largely a rendering hack. man_made=storage_tank is more semantic. But German mappers found that adding building=yes makes it render nice for areas, and documented that on the wiki.

"Don't tag for the rendering" might be a mantra among experienced users, but with osm-carto rendering lagging so far behind tagging behavior, it's not reality.

building=storage_tank + man_made=storage_tank seems a reasonable compromise.

comment:12 Changed 4 years ago by mkoniecz

building=storage_tank in my opinion is not an incorrect tag to describe structures like http://en.wikipedia.org/wiki/Storage_tank#/media/File:Fuel_tank_gnangarra.jpg - therefore IMHO it is not a tagging for renderer.

It is widely accepted that storage tanks should be described as man_made=storage_tank - but it does not mean that using also building=storage_tank is incorrect

Using building tag is helpful for all data consumers, not only for default map style. It allows to check just for building key rather than looking for many key and key-value pairs what simplifies processing of osm data

[building]

query is much better than say

[building or man_made=storage_tank or man_made=water_tower or aeroway=terminal or (amenity=place_of_worship and building!=no) <many many many more>]

Last edited 4 years ago by mkoniecz (previous) (diff)

comment:13 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8328/josm:

fix #11339 - add man_made=storage_tank to preset and mappaint style (modified patch by brycenesbitt; icon retrieved from gasometer.png)

comment:14 Changed 4 years ago by Klumbumbus

In 8335/josm:

see #11339 - fix position of preset entry man_made=storage_tank

Changed 4 years ago by skyper

Attachment: josm_11339_add.patch added

additional tags patch

comment:15 in reply to:  3 Changed 4 years ago by skyper

Replying to skyper:

How about adding capacity=* and material=* ?

Please, find additional patch adding some more common tags. Not sure if building=* should be optional, though.

comment:16 Changed 4 years ago by brycenesbitt

@skyper could you use http://wiki.openstreetmap.org/wiki/Key:building:material to avoid confusion with contents?

At this point I feel building should be mandatory. In the rare case (of an underground tank?) the mapper can just delete the extra tag.

Changed 4 years ago by skyper

Attachment: josm_11339_addv2.patch added

patch with building:material

comment:17 in reply to:  16 Changed 4 years ago by skyper

Replying to brycenesbitt:

@skyper could you use osmwiki:Key:building:material to avoid confusion with contents?

At this point I feel building should be mandatory. In the rare case (of an underground tank?) the mapper can just delete the extra tag.

Still not happy with building=* but not the right time to discuss. See optional patch version 2.

comment:18 Changed 4 years ago by brycenesbitt

If we're designing tagging (rather than providing presets for existing use) then we should also get open top vs. closed top into there.

comment:19 Changed 4 years ago by Klumbumbus

If we skip (the useless value) capacity=unknown, then capacity is used only 22 times on man_made=storage_tank. (http://overpass-turbo.eu/s/9pc). For man_made=water_tower water_tower:volume is used even more then capacity. capacity wiki page does not mention man_made=* It seems there is no clear established tagging scheme so far.

Last edited 4 years ago by Klumbumbus (previous) (diff)

comment:20 Changed 4 years ago by Klumbumbus

In 8386/josm:

see #11339 - adjust presets for man_made=storage_tank|gasometer|water_tower|bunker_silo amenity=bench

comment:21 in reply to:  18 Changed 4 years ago by Klumbumbus

Replying to brycenesbitt:

If we're designing tagging (rather than providing presets for existing use)

The Guidelines at DevelopersGuide/DefaultPresets didn't change.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.