Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11261 closed defect (fixed)

Do not run test depending on parent or other member objects on incomplete data

Reported by: skyper Owned by: team
Priority: normal Milestone: 15.08
Component: Core validator Version:
Keywords: template_report incomplete false positive Cc:


What steps will reproduce the problem?

  1. download a node with entrance=* or public_transport=stop_position without parents alternatively a member of associated with role=house without a nearby member with role=street
  2. run validator on all data

What is the expected result?

No warnings about entrance=* or public_transport=stop_position not been connected to way. Likewise no warning about house being to far from street.

What happens instead?

Lots of false positives caused by incomplete data.

Please provide any additional information below. Attach a screenshot if possible.

The examples above are far from complete, Think there is a warning about ford and the warning about links not connected with proper highway are more examples.

Generally, test on incomplete data are mostly only useful on complete objects but there are exceptions like role test.

Hope, in the end we end up with faster validator run and less false positives.

Repository Root:
Build-Date: 2015-03-23 02:30:58
Last Changed Author: stoecker
Revision: 8149
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
Last Changed Date: 2015-03-22 23:16:08 +0100 (Sun, 22 Mar 2015)
Last Changed Rev: 8149

Identification: JOSM/1.5 (8149 en) Linux Debian GNU/Linux 7.8 (wheezy)
Memory Usage: 478 MB / 882 MB (91 MB allocated, but free)
Java version: 1.7.0_75, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u75-2.5.4-1~deb7u1
Dataset consistency test: No problems found

- OpeningHoursEditor (30962)
- conflation (0.1.7)
- download_along (30892)
- imagery-xml-bounds (31019)
- imagery_offset_db (31056)
- jts (31002)
- mirrored_download (30962)
- photoadjust (30964)
- reverter (30990)
- tag2link (30962)
- terracer (30892)
- todo (29154)
- undelete (30892)
- utilsplugin2 (31040)
- waydownloader (30892)
- wikipedia (31035)

Attachments (0)

Change History (5)

comment:1 by skyper, 9 years ago

See also #11150

comment:2 by Klumbumbus, 9 years ago

Resolution: fixed
Status: newclosed

In 8522/josm:

fix #11261 - add pseudo class :in-downloaded-area to isolated nodes test

comment:3 by Klumbumbus, 9 years ago

Milestone: 15.07

comment:4 by Don-vip, 9 years ago

See #11677

comment:5 by Don-vip, 9 years ago

Milestone: 15.0715.08

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.