Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11165 closed defect (fixed)

surplus space in "type of construction" preset

Reported by: aceman Owned by: team
Priority: trivial Milestone: 15.02
Component: Internal preset Version: latest
Keywords: Cc:

Description

There seems to be a surplus space in the preset values:
<combo key="structure" text="Type of construction" values="lattice,tubular,solid " />
at http://josm.openstreetmap.de/browser/josm/trunk/data/defaultpresets.xml#L5753

I am not sure if the value "solid " gets into the data, hopefully the validator will catch it (but some users may ignore it). But the value does get to be translated at launchpad.

Attachments (0)

Change History (8)

comment:1 Changed 5 years ago by aceman

Oh, also see another one
<combo key="enforcement" text="Type of enforcement" values="maxheight,maxweight,maxspeed,mindistance,traffic_signals,check " />
at http://josm.openstreetmap.de/browser/josm/trunk/data/defaultpresets.xml#L8048

comment:2 Changed 5 years ago by Klumbumbus

Milestone: 15.03

Next milestone, to avoid untranslated strings.

comment:3 in reply to:  description Changed 5 years ago by Klumbumbus

Replying to aceman:

I am not sure if the value "solid " gets into the data, hopefully the validator will catch it (but some users may ignore it).

The space is removed as soon as you apply the preset.

There are zero uses of "solid " atm. see http://taginfo.openstreetmap.org/tags/structure=solid%20

comment:4 Changed 5 years ago by stoecker

We anyway delayed release, so fix it :-)

comment:5 in reply to:  4 Changed 5 years ago by Klumbumbus

Replying to stoecker:

We anyway delayed release, so fix it :-)

Do you plan one more i18n update?

comment:6 Changed 5 years ago by stoecker

Yes. At least one.

comment:7 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8105/josm:

fix #11165 - typos

comment:8 Changed 5 years ago by Klumbumbus

Milestone: 15.0315.02

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.