Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11047 closed enhancement (fixed)

changeset: no length check for the source field

Reported by: aseerel4c26 Owned by: team
Priority: minor Milestone: 15.01
Component: Core Version: tested
Keywords: tags changeset source Cc:

Description (last modified by Don-vip)

apparently there is no length check for the "source" field for changesets although it looks like the "comment" field. So, it also should behave like it.

  • Revision: 7906
  • Linux
  • Java version: 1.8.0_31, Oracle Corporation, OpenJDK 64-Bit Server VM

What steps will reproduce the problem?

  1. make some data changes and click the upload button
  2. type too many letters (more than 255, IIRC) into the source field
  3. hit "upload"

What is the expected result?

the same like for the "comment" field: not even possible to enter too many characters

What happens instead?

error from server which leads to the error message:

Error message(untranslated): ChangesetTag 28523682,source: v: is too long (maximum is 255 characters) ("josm bug 11047 - lllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllll")

Workaround: At least the (long) comment is saved by JOSM, so it can be recovered with the drop-down button and shortened.

Attachments (0)

Change History (3)

comment:1 Changed 5 years ago by Don-vip

Description: modified (diff)
Keywords: changeset source added
Milestone: 15.01

comment:2 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7995/josm:

fix #11047 - changeset: no length check for the source field

comment:3 Changed 5 years ago by aseerel4c26

thanks, works! tested with josm 7995.

While testing it I noticed a small inconvenience: there is no user feedback why pasting a long text does not work. It just is not pasted. However, likely it is not worth the effort to implement an unobtrusive user feedback (e.g. a flashing red right text box border) if too long text is tried to type or paste.

Quite of the same importance: you are still able to enter too long text in the second tab of the changeset upload window. If you enter a too long source there (you get no feedback that it is too long) and switch back to the first tab, then you complete source is emptied. All work compiling that long source comment is lost. Since very very few users will try to enter such long source comments AND use the raw tag editing of changesets, I think this is also not worth a new bug report.

(no new bug reports)

Last edited 5 years ago by aseerel4c26 (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.