Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#10866 closed enhancement (fixed)

"Download area too large" warning apparently not adjusted to notes density

Reported by: aseerel4c26 Owned by: ToeBee
Priority: minor Milestone: 15.04
Component: Core notes Version: latest
Keywords: Cc:

Description (last modified by aseerel4c26)

notes are (and will be in future... hopefully) much more sparse than osm data. Downloading much bigger areas than OSM data should not generate a warning (see attached screenshot). A rectange of half Germany (and a bit Netherlands, Belgium) was rejected by the server. But a quarter of Germany went through (and quite fast).

JOSM Version 7819.

Attachments (1)

notes-areatoolarge.png (568.3 KB) - added by aseerel4c26 5 years ago.
notes - screenshot of warning when just the area around a city was downloaded

Download all attachments as: .zip

Change History (11)

Changed 5 years ago by aseerel4c26

Attachment: notes-areatoolarge.png added

notes - screenshot of warning when just the area around a city was downloaded

comment:1 Changed 5 years ago by aseerel4c26

Description: modified (diff)

comment:2 Changed 5 years ago by aseerel4c26

Priority: normalminor

comment:3 Changed 5 years ago by ToeBee

The maximum area for note requests is 25 square degrees. This compares to the 0.25 square degrees for map data calls. So it is significantly different. Also, the area limitation is not even a good indication of whether the selection will actually work or not for map data. There is a 50,000 node limit per map call that will kick in long before the 0.25 square degree limit in any semi-densely mapped area. So I view that warning as a pretty rough approximation anyway... But I guess if the notes checkbox is the only one checked I could probably change that warning.

comment:4 Changed 5 years ago by skyper

Are there numbers for gpx download limit ?

Think we need a different limit for each option.
How are different server handled ?

comment:5 Changed 5 years ago by ToeBee

If I'm reading the ruby correctly (which I will not guarantee) then the area limit for GPX download is also 0.25 square degrees. I think it uses the same function as the map data call to check the bbox size. And of course there is the 5,000 trackpoint per request limit which JOSM already handles by paging through the results. The note API doesn't do paging, it just cuts you off at 10,000.

So 3 different ways of downloading data from the same server. Welcome to OSM :)

comment:6 Changed 5 years ago by Don-vip

Component: CoreCore notes

Moving notes tickets to their own component

comment:7 Changed 5 years ago by Don-vip

Keywords: notes removed

comment:8 Changed 5 years ago by simon04

Resolution: fixed
Status: newclosed

In 8215/josm:

fix #10866 - Adjust size check for "Download area too large" warning when only notes are downloaded

comment:9 Changed 5 years ago by simon04

Milestone: 15.04

comment:10 Changed 4 years ago by aseerel4c26

Thank you, simon04! It seems to work fine in version 8229 :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ToeBee.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.