Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10854 closed enhancement (fixed)

[PATCH] Move 'Toggle image thumbnail preview' feature to JOSM core

Reported by: bastiK Owned by: team
Priority: normal Milestone: 15.01
Component: Core image mapping Version:
Keywords: photomapping Cc: holgermappt

Description

The photoadjust feature toggle image thumbnail preview should be in JOSM core, as it is not related to adjusting images and would be useful to every photo mapper.

I think it is good as is, but a checkbox image thumbnail preview on the map would make more sense UI-wise because you could tell from the menu if thumbnail preview is on or off.

Also we should make sure that thumbnail loading is stopped when the menu item is clicked, as the loading takes a lot of computing power.

Attachments (2)

togglegit.png (550 bytes) - added by holgermappt 5 years ago.
Icon for toggle icon/thumbnail menu. License is GPL v2 or later (current JOSM license).
GeoImageLayer_showThumbnails.patch (3.8 KB) - added by holgermappt 5 years ago.
Patch file for this ticket

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by holgermappt

I can prepare a JOSM core patch. I see two up-votes within the last 24 hours, so this might be of general interest.

Where would that image thumbnail preview on the map checkbox be located? In the Preferences Display Settings, e.g. Look and Feel? Or in the View menu? Or in the Geotagged Images panel?

comment:2 Changed 5 years ago by bastiK

I would suggest a per layer setting in the right click menu of the image layer (as it is now in the plugin).

comment:3 Changed 5 years ago by holgermappt

Ah, you mean a checkbox for the toggle menu item. Like Show Text/Icons in the GPX layer.

comment:4 Changed 5 years ago by bastiK

Yes, exactly!

Changed 5 years ago by holgermappt

Attachment: togglegit.png added

Icon for toggle icon/thumbnail menu. License is GPL v2 or later (current JOSM license).

Changed 5 years ago by holgermappt

Patch file for this ticket

comment:5 Changed 5 years ago by holgermappt

Cc: holgermappt added
Component: Plugin photoadjustCore image mapping
Owner: changed from holgermappt to team
Summary: Move 'Toggle image thumbnail preview' feature to JOSM core[PATCH] Move 'Toggle image thumbnail preview' feature to JOSM core

The patch moves the Toggle image thumbnail preview menu item from the photoadjust plugin to the JOSM core. The functionality was changed to show thumbnails (on/off) and the wording of the menu entry was changed accordingly. The patch includes the image togglegit.png, which is not part of the patch file. The JOSM revision needs to be inserted for class ShowThumbnailAction (@since tbd).

comment:6 Changed 5 years ago by bastiK

Resolution: fixed
Status: newclosed

In 7935/josm:

applied #10920, applied #10854 - Move 'Toggle image thumbnail preview' feature to JOSM core (patch by holgermappt, modified)

comment:7 Changed 5 years ago by bastiK

Thanks, this function completes the geoimage feature and has been missing for years!

comment:8 Changed 5 years ago by holgermappt

Two minor details: My patch includes the @since tbd in ShowThumbnailAction because the @since was added to my previous patches. It was committed as-is with the tbd, but should be @since 7935 or be removed.

In ticket:10920 but same commit: In GeoImageLayer.java the variable thumbusLoaderExecutor was introduced. Should that be thumbsLoaderExecutor (thumbs without u)?

Thanks for accepting my patches.

comment:9 Changed 5 years ago by stoecker

In 7954/josm:

see #10854 - fix typos

comment:10 Changed 5 years ago by Don-vip

Milestone: 15.01

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.