#10854 closed enhancement (fixed)
[PATCH] Move 'Toggle image thumbnail preview' feature to JOSM core
| Reported by: | bastiK | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 15.01 |
| Component: | Core image mapping | Version: | |
| Keywords: | photomapping | Cc: | holgermappt |
Description
The photoadjust feature toggle image thumbnail preview should be in JOSM core, as it is not related to adjusting images and would be useful to every photo mapper.
I think it is good as is, but a checkbox image thumbnail preview on the map would make more sense UI-wise because you could tell from the menu if thumbnail preview is on or off.
Also we should make sure that thumbnail loading is stopped when the menu item is clicked, as the loading takes a lot of computing power.
Attachments (2)
Change History (12)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
I would suggest a per layer setting in the right click menu of the image layer (as it is now in the plugin).
comment:3 by , 10 years ago
Ah, you mean a checkbox for the toggle menu item. Like Show Text/Icons in the GPX layer.
by , 10 years ago
| Attachment: | togglegit.png added |
|---|
Icon for toggle icon/thumbnail menu. License is GPL v2 or later (current JOSM license).
comment:5 by , 10 years ago
| Cc: | added |
|---|---|
| Component: | Plugin photoadjust → Core image mapping |
| Owner: | changed from to |
| Summary: | Move 'Toggle image thumbnail preview' feature to JOSM core → [PATCH] Move 'Toggle image thumbnail preview' feature to JOSM core |
The patch moves the Toggle image thumbnail preview menu item from the photoadjust plugin to the JOSM core. The functionality was changed to show thumbnails (on/off) and the wording of the menu entry was changed accordingly. The patch includes the image togglegit.png, which is not part of the patch file. The JOSM revision needs to be inserted for class ShowThumbnailAction (@since tbd).
comment:7 by , 10 years ago
Thanks, this function completes the geoimage feature and has been missing for years!
comment:8 by , 10 years ago
Two minor details: My patch includes the @since tbd in ShowThumbnailAction because the @since was added to my previous patches. It was committed as-is with the tbd, but should be @since 7935 or be removed.
In ticket:10920 but same commit: In GeoImageLayer.java the variable thumbusLoaderExecutor was introduced. Should that be thumbsLoaderExecutor (thumbs without u)?
Thanks for accepting my patches.
comment:10 by , 10 years ago
| Milestone: | → 15.01 |
|---|
I can prepare a JOSM core patch. I see two up-votes within the last 24 hours, so this might be of general interest.
Where would that image thumbnail preview on the map checkbox be located? In the Preferences Display Settings, e.g. Look and Feel? Or in the View menu? Or in the Geotagged Images panel?