refine crossing icons

[Klumbumbus]

Currently every highway=crossing is represented by this zebra-crossing icon:

Here is a refinement:
highway=crossing (default icon)
crossing=unmarked
crossing=island
crossing_ref=zebra
crossing=traffic_signals

Once #10217 is done, they can also be nicely aligned.

[Klumbumbus]

In 7794/josm:

fix #10831 - refine crossing icons

[aceman]

There is a non-trivial amount of occurences where people put highway=traffic_signals (instead of =crosssing) together with crossing=* (​http://taginfo.openstreetmap.org/tags/highway=traffic_signals#combinations), meaning there is a crossing for pedestrians and also a signal for cars on the same spot. Would it be possible to support that with icons? Today I think the icon for highway=traffic_signals overrides the crossing icon.

[Klumbumbus]

Yes, before and after this patch highway=traffic_signals always shows:

What about this one for highway=traffic_signals+crossing=traffic_signals:

[Klumbumbus]

Or do you mean also icons for all other combinations of highway=traffic_signals + crossing=*? Are there more valid combinations except highway=traffic_signals + crossing=traffic_signals?

[Klumbumbus]

Or we do always display for crossing=traffic_signals (also with highway=traffic_signals), because every crossing traffic signal for pedestrians has also traffic signals for the motorized traffic. But not every junction with traffic signals for the motorized traffic has a crossing signal for pedestrians.

[aceman]

Replying to Klumbumbus:

Or we do always display for crossing=traffic_signals (also with highway=traffic_signals), because every crossing traffic signal for pedestrians has also traffic signals for the motorized traffic. But not every junction with traffic signals for the motorized traffic has a crossing signal for pedestrians.

That is an interesting analysis. However the signals may be mapped as 2 nodes, one for crossing=traffic_signals (foot) and one for highway=traffic_signals (car). In that case, the foot crossing does not automatically imply there is also a car signal at the same spot (it would mean a duplicity with the second node). So I think we should display whatever the mapper tagged without any assumptions yet (those assumptions also aren't on the wiki).

So the icon https://josm.openstreetmap.de/raw-attachment/ticket/10831/traffic-light_crossing2.png
for "highway=traffic_signals+crossing=traffic_signals" would be nice. And a second variant for highway=traffic_signals+crossing=* (all other values except 'traffic_signals' and 'no')" . With a 3 light signal and maybe little zebra stripes at the side (from icon ​https://trac.openstreetmap.org/intertrac/source%3Asubversion/applications/share/map-icons/classic.small/vehicle/crossing_ref_zebra.svg%3Fformat%3Draw).

[Klumbumbus]

Is there a .svg of ?

[Klumbumbus]

In 7815/josm:

fix #10831 - refine crossing icons when used together with highway=traffic_signals