Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#10831 closed enhancement (fixed)

refine crossing icons

Reported by: Klumbumbus Owned by: Klumbumbus
Priority: normal Milestone: 14.12
Component: Internal mappaint style Version:
Keywords: Cc:

Description (last modified by Klumbumbus)

Currently every highway=crossing is represented by this zebra-crossing icon: No image "subversion/applications/share/map-icons/classic.small/vehicle/zebra_crossing.png" attached to osm:source

Here is a refinement:
No image "subversion/applications/share/map-icons/classic.small/vehicle/crossing.svg" attached to osm:source highway=crossing (default icon)
No image "subversion/applications/share/map-icons/classic.small/vehicle/crossing_unmarked.svg" attached to osm:source crossing=unmarked
No image "subversion/applications/share/map-icons/classic.small/vehicle/crossing_island.svg" attached to osm:source crossing=island
No image "subversion/applications/share/map-icons/classic.small/vehicle/crossing_ref_zebra.svg" attached to osm:source crossing_ref=zebra
No image "subversion/applications/share/map-icons/classic.small/vehicle/crossing_traffic_signals.svg" attached to osm:source crossing=traffic_signals

Once #10217 is done, they can also be nicely aligned.

Attachments (1)

traffic-light_crossing2.png (456 bytes) - added by Klumbumbus 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 7794/josm:

fix #10831 - refine crossing icons

comment:2 Changed 8 years ago by aceman

There is a non-trivial amount of occurences where people put highway=traffic_signals (instead of =crosssing) together with crossing=* (http://taginfo.openstreetmap.org/tags/highway=traffic_signals#combinations), meaning there is a crossing for pedestrians and also a signal for cars on the same spot. Would it be possible to support that with icons? Today I think the icon for highway=traffic_signals overrides the crossing icon.

comment:3 Changed 8 years ago by Klumbumbus

Yes, before and after this patch highway=traffic_signals always shows: No image "subversion/applications/share/map-icons/classic.small/vehicle/restriction/traffic-light.png" attached to osm:source

What about this one for highway=traffic_signals+crossing=traffic_signals:

Changed 8 years ago by Klumbumbus

Attachment: traffic-light_crossing2.png added

comment:4 Changed 8 years ago by Klumbumbus

Or do you mean also icons for all other combinations of highway=traffic_signals + crossing=*? Are there more valid combinations except highway=traffic_signals + crossing=traffic_signals?

comment:5 Changed 8 years ago by Klumbumbus

Or we do always display No image "subversion/applications/share/map-icons/classic.small/vehicle/crossing_traffic_signals.png" attached to osm:source for crossing=traffic_signals (also with highway=traffic_signals), because every crossing traffic signal for pedestrians has also traffic signals for the motorized traffic. But not every junction with traffic signals for the motorized traffic has a crossing signal for pedestrians.

comment:6 in reply to:  5 Changed 8 years ago by aceman

Replying to Klumbumbus:

Or we do always display No image "subversion/applications/share/map-icons/classic.small/vehicle/crossing_traffic_signals.png" attached to osm:source for crossing=traffic_signals (also with highway=traffic_signals), because every crossing traffic signal for pedestrians has also traffic signals for the motorized traffic. But not every junction with traffic signals for the motorized traffic has a crossing signal for pedestrians.

That is an interesting analysis. However the signals may be mapped as 2 nodes, one for crossing=traffic_signals (foot) and one for highway=traffic_signals (car). In that case, the foot crossing does not automatically imply there is also a car signal at the same spot (it would mean a duplicity with the second node). So I think we should display whatever the mapper tagged without any assumptions yet (those assumptions also aren't on the wiki).

So the icon https://josm.openstreetmap.de/raw-attachment/ticket/10831/traffic-light_crossing2.png
for "highway=traffic_signals+crossing=traffic_signals" would be nice. And a second variant for highway=traffic_signals+crossing=* (all other values except 'traffic_signals' and 'no')" . With a 3 light signal and maybe little zebra stripes at the side (from icon https://trac.openstreetmap.org/intertrac/source%3Asubversion/applications/share/map-icons/classic.small/vehicle/crossing_ref_zebra.svg%3Fformat%3Draw).

comment:7 Changed 8 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

Is there a .svg of No image "subversion/applications/share/map-icons/classic.small/vehicle/restriction/traffic-light.png" attached to osm:source?

comment:8 Changed 8 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 7815/josm:

fix #10831 - refine crossing icons when used together with highway=traffic_signals

comment:9 Changed 8 years ago by Klumbumbus

Description: modified (diff)

comment:10 Changed 8 years ago by Klumbumbus

replaced by svg:
No image "subversion/applications/share/map-icons/classic.small/vehicle/crossing_traffic_signals.svg" attached to osm:source
No image "subversion/applications/share/map-icons/classic.small/vehicle/traffic_signals.svg" attached to osm:source

added:
No image "subversion/applications/share/map-icons/classic.small/vehicle/traffic_signals_crossing.svg" attached to osm:source
No image "subversion/applications/share/map-icons/classic.small/vehicle/traffic_signals_crossing_ref_zebra.svg" attached to osm:source
No image "subversion/applications/share/map-icons/classic.small/vehicle/traffic_signals_crossing_island.svg" attached to osm:source
No image "subversion/applications/share/map-icons/classic.small/vehicle/traffic_signals_crossing_traffic_signals.svg" attached to osm:source

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.