[PATCH] ImproveWayAccuracy produces self-intersecting ways

[akks]

Reported by Vitalts on forum:
​http://forum.openstreetmap.org/viewtopic.php?pid=469490#p469490

How to reproduce:

1. Open attached .osm file
2. Enter Improve Way Accuracy mode W and hold Ctrl
3. Move mouse near the east node (see animated gif by Vitalts)

Self-intersecting ways are not expected to appear.

Solution:
There is some rounding error in sin/cos based Geometry.getSegmentAltituteIntersection (transferred from IWA
plugin? misprint also...)

The function does actually the same as closesPointTo but returns null sometimes. It is used only in IWA mode and in NanoLog plugin.

• One solution is to remove this function and use closestPointToSegment and additional checks.
• Another solution is to keep separate function but use the code from closestPointToSegment (no other class changing will be neeeded, patch attached)

@team: could someone check the patch with the second solution?

[stoecker]

If it does the same, drop the function and fix plugin calls. Why keep a duplicate function?

[stoecker]

The name is anyway wrong "altitute" :-)

[akks]

Yes, the misprint is also a problem :)

However, closestPointToSegment does not tell if the nearest point is inside the segment (extra unneeded operations to check?), so maybe the separate function is still needed...

[stoecker]

If it's only used at one place in core and there the other function is better, then there is no reason to keep it except you find a good reason.

[akks]

OK, then I'll delete the Geometry.getSegmentAltituteIntersection and fix call in NanoLog this evening.
The patch follows.

[stoecker]

Otherwise ьeasurу the angle

Should be "Otherwise measure the angle". But ь isn't m in cyrillic. Simply a typo? :-)

[akks]

In 7776/josm:

fix #10821: ImproveWayAccuracy produced self-intersecting ways
remove Geometry.getSegmentAltituteIntersection method (use closestPointToSegment)

[akks]

Thank you, fixed the typo and committed. Will fix NanoLog now...