Modify

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#10746 closed enhancement (fixed)

[patch] Add Notes checkbox in DownloadDialog

Reported by: ToeBee Owned by: team
Priority: normal Milestone: 14.11
Component: Core notes Version:
Keywords: Cc: ToeBee

Description

This adds a checkbox for downloading notes into the download UI. It is still hidden behind the osm.notes.enableDownload preference which still defaults to false. But if this preference is enabled, the download dialog will behave like I expect it will when notes are unhidden for everyone.

A note about GridbagConstraints. I'm not sure what is going on with the spacing between the checkboxes. As far as I can tell, the insets() function creates margins around objects. The OSM data checkbox and GPX checkbox have 1 or 5 as their right and left margins and have a significant space between them when they are rendered. When I added the notes checkbox with a 5 for the left margin, it appeared right next to the GPX checkbox. I achieved some separation by bumping the left margin up to 50 (pixels?) but am not quite sure what is going on there or if 50 is the ideal value.

Attachments (1)

notes_checkbox.patch (4.8 KB) - added by ToeBee 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by ToeBee

Attachment: notes_checkbox.patch added

comment:1 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7722/josm:

fix #10746 - Add Notes checkbox in DownloadDialog (patch by ToeBee)

comment:2 Changed 5 years ago by Klumbumbus

Component: CoreCore notes
Keywords: notes removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.