Modify

Opened 5 years ago

Closed 5 years ago

#10679 closed defect (fixed)

icons for landuse=* in mappaint style?

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 14.11
Component: Internal mappaint style Version:
Keywords: Cc:

Description

JOSM validator warns about landuse=* on nodes. However the internal mappaint style displays icons for landuse on nodes. Regarding presets, some landuse presets allow nodes, some not. It is a bit inconsistent if the icon is displayed in the map view but you cannot access the preset in the Tags/Membership dialog because the preset does not allow nodes.

So should we remove the icons for landuse on nodes in the mappaint style or change the icon to the deprecated icon? Or should we do nothing to support tagging landuses on nodes for areas with low resolution aerial imagery?


landuse values which have an icon in the mappaint style: farm, farmland, meadow, vineyard, quarry, landfill, basin, reservoir, forest, allotments, greenhouse_horticulture, plant_nursery, grass, residential, garages, farmyard, retail, commercial, industrial, brownfield, greenfild, railway, construction, military, cemetery, village_green, recreation_ground

Attachments (0)

Change History (17)

comment:1 Changed 5 years ago by bastiK

+1 for consistency.

What does taginfo / wiki say? Any discussions on forum / mailing list?

comment:2 Changed 5 years ago by Don-vip

Milestone: 14.11

+1. I'd say let's have a single rule like:

node[landuse] {
    icon-image: "misc/deprecated.png";
    ...
}

and drop support of presets on nodes for all impacted landuses.

comment:3 Changed 5 years ago by mkoniecz

Lets remember that icons on recently added tags list should be not affected by this change.

comment:4 in reply to:  3 ; Changed 5 years ago by Klumbumbus

Replying to mkoniecz:

Lets remember that icons on recently added tags list should be not affected by this change.

If I understand correct, then in this list it first searches for matching icons in the mappaint styles. If there are no (or no mappaint style is active) then it searches for matching icons in presets. So if we remove the icons from the mappaint style it should use the icons from the presets. However currently there are a lot tags which have different icons in the mappaint style and in the preset. Especially for sport tags. Is there a reason for this? I think this should be unified.

comment:5 Changed 5 years ago by Klumbumbus

taginfo statistics:
1: 260.000 nodes, 11.113.000 ways, 378.000 relations with landuse=*
2: values of nodes with landuse=*: 86.000 forest, 67.000 reservoir, 38.000 quarry, 15.000 vineyard,...

I think a lot of the landuse nodes are "misused" for label placement. Random example.

comment:6 Changed 5 years ago by Klumbumbus

wiki:
info box here says do not use on nodes, while the table on this page allows it for a lot of landuses. I'm suprised about this. Also I can't really find any discussions about this topic.

comment:7 Changed 5 years ago by mkoniecz

I think a lot of the landuse nodes are "misused" for label placement. ​Random example.

I created "Names from landuse nodes are displayed" ticket on https://github.com/gravitystorm/openstreetmap-carto/issues/1100

comment:8 in reply to:  4 Changed 5 years ago by bastiK

Replying to Klumbumbus:

However currently there are a lot tags which have different icons in the mappaint style and in the preset. Especially for sport tags. Is there a reason for this? I think this should be unified.

+1

Replying to Klumbumbus:

wiki:
info box here says do not use on nodes, while the table on this page allows it for a lot of landuses. I'm suprised about this. Also I can't really find any discussions about this topic.

If there is no aerial imagery it may be the only option, (e.g. small landuse=cemetery in forest), but we don't have to encourage this use.

comment:9 Changed 5 years ago by Klumbumbus

In 7711/josm:

see #10679 - drop support of landuse=* on nodes in presets and mappaint style. rework some icons for presets (add a few, replace some generic by special ones)

comment:10 Changed 5 years ago by skorasaurus

For perspective, the GNIS import in the USA (in 2008-09) imported many nodes (my guess is thousands, although I am not sure) that were tagged as landuse= (especially reservoir) for items which should have been imported as polygons and they still haven't be remapped as polygons yet.

Have you run an analysis to see how many of these landuse nodes were in the USA?

comment:11 Changed 5 years ago by Klumbumbus

Only the taginfo map for nodes, which shows landuse nodes all over the world. However USA is fully filled with red dots.

comment:12 Changed 5 years ago by Klumbumbus

I suggest to drop node support also for natural=scree, scrub, fell, heath, tree row, wood, wetland, water, coastline, sand

And complete deprecate natural=land

comment:13 in reply to:  12 ; Changed 5 years ago by skyper

Replying to Klumbumbus:

I suggest to drop node support also for natural=scree, scrub, fell, heath, tree row, wood, wetland, water, coastline, sand

And complete deprecate natural=land

The least we need are validator warnings about all the nodes not rendered anymore. Do not know if we have one for each case already.

comment:14 in reply to:  13 ; Changed 5 years ago by skyper

Replying to skyper:

Replying to Klumbumbus:

I suggest to drop node support also for natural=scree, scrub, fell, heath, tree row, wood, wetland, water, coastline, sand

And complete deprecate natural=land

The least we need are validator warnings about all the nodes not rendered anymore. Do not know if we have one for each case already.

Reading helps: We have the warning already.

comment:15 in reply to:  14 Changed 5 years ago by Klumbumbus

Replying to skyper:

Reading helps: We have the warning already.

Only for landuse=* on nodes, but not for the mentioned natural=* on nodes

comment:16 Changed 5 years ago by Klumbumbus

In 7735/josm:

see #10679 - drop support of some natural=* on nodes in presets and mappaint style. Add validator messages, change two icons in presets, add mappaint style for some natural=*.

comment:17 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

There is still some work in icon unification (preset - mappaint), but this is not the main intention of this ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.