Opened 11 years ago

Last modified 11 years ago

#10647 closed defect

Shortcuts are activated while in dialogs. — at Version 1

Reported by: akks Owned by: team
Priority: major Milestone: 14.10
Component: Core Version: latest
Keywords: template_report, shortcut Cc:

Description (last modified by akks)

(reported by maxphizik on Russian forum)

What steps will reproduce the problem?

  1. Use JOSM newer than r6318.
  2. Enter drawing mode (A).
  3. Press Alt-A or open any other window.
  4. Type text with multiple 'A'

What is the expected result?

Just entering A or ignoring keypress

What happens instead?

Angle snapping turns on and off :)
The same with other keyDetector-based events.

Please provide any additional information below. Attach a screenshot if possible.

Maybe it is combination of r6318 and my r7609...

That focus listening and checking is always buggy. We'd beter minimize it but I do not know convenient way.
Maybe remove focus checking in AnvacedKeyPressDetector and make it enabled/disabled at right moments? Do not know, need to think together with the team.

By the way, that MASSIVE shortcut activation/deactivation in http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/widgets/DisableShortcutsOnFocusGainedTextField.java seems ineffective. There should be simpler solution like correct filtering in processKeyEvent.

Revision: 7620
Is-Local-Build: true
Build-Date: 2014-10-18 23:25:05

Identification: JOSM/1.5 (7620 SVN ru) Windows 8.1 64-Bit
Memory Usage: 163 MB / 1796 MB (54 MB allocated, but free)
Java version: 1.8.0_25, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM

Plugins:
- FastDraw (30710)
- ImageryCache (30416)
- InfoMode (30416)
- PicLayer (30436)
- buildings_tools (30485)
- imagery_offset_db (30534)
- measurement (30641)
- reltoolbox (30587)
- reverter (30521)
- tagging-preset-tester (30592)
- utilsplugin2 (30460)
- waydownloader (30693)
- waypoint_search (30416)

Change History (1)

comment:1 by akks, 11 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.