Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10606 closed enhancement (fixed)

[patch] add ID of note

Reported by: Klumbumbus Owned by: ToeBee
Priority: normal Milestone: 14.12
Component: Core notes Version:
Keywords: template_report Cc:

Description

Please display also the ID of notes in the notes dialog. When I make changes according to notes, I type as source tag of the changeset "note 123456". However it is not possible atm to find out the ID of a note within JOSM. You need to go to the osm homepage.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-10-07 00:39:17
Last Changed Author: Don-vip
Revision: 7606
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-10-07 02:37:12 +0200 (Tue, 07 Oct 2014)
Last Changed Rev: 7606

Identification: JOSM/1.5 (7606 en) Windows 7 32-Bit
Memory Usage: 492 MB / 742 MB (99 MB allocated, but free)
Java version: 1.7.0_67, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=49785, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
- DirectUpload (30697)
- HouseNumberTaggingTool (30416)
- OpeningHoursEditor (30609)
- PicLayer (30436)
- Tracer2 (30416)
- buildings_tools (30485)
- download_along (30416)
- editgpx (30634)
- imagery_offset_db (30534)
- measurement (30641)
- notes (v0.9.4)
- public_transport (30664)
- reltoolbox (30587)
- reverter (30521)
- terracer (30643)
- turnrestrictions (30651)
- undelete (30416)
- utilsplugin2 (30460)

Last errors/warnings:
- W: Detected deprecated 'canvas{background-color}' in 'https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip' which will be removed shortly. Use 'fill-color' instead.

Attachments (1)

show_note_id.patch (2.2 KB) - added by ToeBee 5 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by skyper

Maybe, this could be an automatic task, gathering all closed nodes. Even better with a possibility to manually decide which of all closed ones to mention.

comment:2 Changed 5 years ago by Klumbumbus

Component: Plugin notesCore
Keywords: notes added
Owner: changed from ToeBee to team

comment:3 Changed 5 years ago by Klumbumbus

Owner: changed from team to ToeBee

comment:4 Changed 5 years ago by ToeBee

Milestone: 14.12
Status: newassigned

It is easy to add the ID number in one of two places:
1) In the note dialog, put it on the front of the text like: 1234: <note text>
2) Add a "Note 1234" to the top of the pop-up in the map frame

Any preference? Do both?

comment:5 Changed 5 years ago by Klumbumbus

I would prefer both :)

(I think more important is in the dialog as long as #10856 is not fixed)

comment:6 Changed 5 years ago by skyper

Somewhere where I can copy the id.

comment:7 Changed 5 years ago by ToeBee

Hmm copying the ID may actually be a little harder. Maybe if I could make the tooltip not disappear if you click inside of it... But I think for right now I'll just add the ID as mentioned above. I really don't feel like hacking around on the tooltip too much more because I really want to replace it with something better altogether which will hopefully open up options for better functionality in general.

Changed 5 years ago by ToeBee

Attachment: show_note_id.patch added

comment:8 Changed 5 years ago by ToeBee

Summary: add ID of note[patch] add ID of note

Well here is a quick fix to at least display the ID. I'm packing for a Christmas trip so while not ideal, this is better than nothing and will have to do for now :)

I will try to come up with something better when the UI is generally redone.

comment:9 Changed 5 years ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 7882/josm:

fix #10606 - add ID of notes (patch by ToeBee)

comment:10 Changed 5 years ago by Klumbumbus

Component: CoreCore notes
Keywords: notes removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ToeBee.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.