Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#10588 closed defect (fixed)

DownloadGpsTask ignores the ProgressMonitor argument given in its constructor

Reported by: Gnonthgol Owned by: team
Priority: normal Milestone: 14.10
Component: Core Version:
Keywords: Cc:

Description

DownloadOsmTask does this correctly. DownloadGpsTask and DownloadNoteTask will ignore this incomming argument and therefore make its own progress monitor based on a modal window that will prevent the user from editing while the download is in process.

Downstream bug: https://github.com/Gnonthgol/JOSM-continuos-download/issues/11

Attachments (0)

Change History (8)

comment:1 Changed 5 years ago by Don-vip

Milestone: 14.10

comment:2 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7597/josm:

fix #10588 - DownloadGpsTask ignores the ProgressMonitor argument given in its constructor

comment:3 Changed 4 years ago by stoecker

@Vincent: Jenkins complains about the useless exception in PluginDownloadTask. Can you remember what your did here? I can't find any side effects, which would justify that change - forgotten debug text?

comment:4 Changed 4 years ago by Don-vip

Jenkins? You mean Findbugs?

comment:5 in reply to:  4 Changed 4 years ago by stoecker

Replying to Don-vip:

Jenkins? You mean Findbugs?

FindBugs in Jenkins Build report to be exact :-)

comment:6 Changed 4 years ago by Don-vip

Be careful, sometimes Findbugs has... bugs :) See https://github.com/findbugsproject/findbugs/pull/76 for example (false positive trigerred for JOSM code). I look into this.

comment:7 Changed 4 years ago by Don-vip

ok so here's the why:

  • in r2817 a private field lastException was introduced but never used
  • in r7596 I commented it
  • in r7597 I commented only the affectation to keep the translation, so we can use it later
  • in r8855 I removed the field

I look how we can use this exception for real, and the warning will be gone :)

comment:8 Changed 4 years ago by Don-vip

In 9621/josm:

see #10588 - properly manage exception feedback in PluginDownloadTask. Removes a Findbugs warning

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.