#10588 closed defect (fixed)
DownloadGpsTask ignores the ProgressMonitor argument given in its constructor
Reported by: | Gnonthgol | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 14.10 |
Component: | Core | Version: | |
Keywords: | Cc: |
Description
DownloadOsmTask does this correctly. DownloadGpsTask and DownloadNoteTask will ignore this incomming argument and therefore make its own progress monitor based on a modal window that will prevent the user from editing while the download is in process.
Downstream bug: https://github.com/Gnonthgol/JOSM-continuos-download/issues/11
Attachments (0)
Change History (8)
comment:1 by , 10 years ago
Milestone: | → 14.10 |
---|
comment:2 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 by , 9 years ago
@Vincent: Jenkins complains about the useless exception in PluginDownloadTask. Can you remember what your did here? I can't find any side effects, which would justify that change - forgotten debug text?
comment:5 by , 9 years ago
comment:6 by , 9 years ago
Be careful, sometimes Findbugs has... bugs :) See https://github.com/findbugsproject/findbugs/pull/76 for example (false positive trigerred for JOSM code). I look into this.
comment:7 by , 9 years ago
ok so here's the why:
- in r2817 a private field lastException was introduced but never used
- in r7596 I commented it
- in r7597 I commented only the affectation to keep the translation, so we can use it later
- in r8855 I removed the field
I look how we can use this exception for real, and the warning will be gone :)
In 7597/josm: