DownloadGpsTask ignores the ProgressMonitor argument given in its constructor

[Gnonthgol]

DownloadOsmTask does this correctly. DownloadGpsTask and DownloadNoteTask will ignore this incomming argument and therefore make its own progress monitor based on a modal window that will prevent the user from editing while the download is in process.

Downstream bug: ​https://github.com/Gnonthgol/JOSM-continuos-download/issues/11

[Don-vip]

In 7597/josm:

fix #10588 - DownloadGpsTask ignores the ProgressMonitor argument given in its constructor

[stoecker]

@Vincent: Jenkins complains about the useless exception in PluginDownloadTask. Can you remember what your did here? I can't find any side effects, which would justify that change - forgotten debug text?

[Don-vip]

Jenkins? You mean Findbugs?

[stoecker]

Replying to Don-vip:

Jenkins? You mean Findbugs?

FindBugs in Jenkins Build report to be exact :-)

[Don-vip]

Be careful, sometimes Findbugs has... bugs :) See ​https://github.com/findbugsproject/findbugs/pull/76 for example (false positive trigerred for JOSM code). I look into this.

[Don-vip]

ok so here's the why:

• in r2817 a private field lastException was introduced but never used
• in r7596 I commented it
• in r7597 I commented only the affectation to keep the translation, so we can use it later
• in r8855 I removed the field

I look how we can use this exception for real, and the warning will be gone :)

[Don-vip]

In 9621/josm:

see #10588 - properly manage exception feedback in PluginDownloadTask. Removes a Findbugs warning