Imagery menu hangs when an external layer icon cannot be loaded

[bundesrainer]

What steps will reproduce the problem?

1. Have imagery layer activated, of which the corresponding icon cannot be loaded via network (in my case: OpenPTMap)
2. Select the imagery menu from the menu bar

What is the expected result?

• The menu should open at once

What happens instead?

• The menu takes about 15 seconds to open

Please provide any additional information below. Attach a screenshot if
possible.

• When the imagery layer with the failing icon is deactivated, everything runs smoothly

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-08-31 21:55:55
Last Changed Author: Don-vip
Revision: 7480
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-08-31 23:51:24 +0200 (Sun, 31 Aug 2014)
Last Changed Rev: 7480

Identification: JOSM/1.5 (7480 de) Windows 7 32-Bit
Memory Usage: 60 MB / 247 MB (9 MB allocated, but free)
Java version: 1.7.0_67, Oracle Corporation, Java HotSpot(TM) Client VM

Plugins:
- DirectDownload (30416)
- DirectUpload (30416)
- PicLayer (30436)
- alignways (30416)
- buildings_tools (30416)
- download_along (30416)
- gpxfilter (30416)
- log4j (30416)
- mapdust (30416)
- measurement (30416)
- routing (30416)
- turnrestrictions (30454)
- utilsplugin2 (30460)
- waydownloader (30416)

Last errors/warnings:
- E: Fehler beim Laden des Bildes 'http://openptmap.de/favicon_pt.png'
- W: Already here java.net.SocketTimeoutException: connect timed out
- E: Fehler beim Laden des Bildes 'http://openptmap.de/favicon_pt.png'

[bundesrainer]

Dialog box at startup, informing that JOSM failed to load an icon

[Don-vip]

while you're in icon stuff, another similar ticket :) The background loading done in r7687 should be applied to imagery menu as well.

[stoecker]

Hmm, in AddImageryLayerAction.java it is asynchronous, bit not in Imagery Layer loading. Again this is more complicated and passing the ImageProvider back is probably required. See also #10688.