Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10499 closed enhancement (fixed)

Preset: Present selection panel in items with only <key> elements

Reported by: malcolmh Owned by: team
Priority: normal Milestone: 14.09
Component: Core Version:
Keywords: preset Cc: lists@…

Description (last modified by malcolmh)

Currently, when an <item> contains only <key> elements, the tags are set and the preset exits without ceremony. This does not give the user a chance to reflect on their choice, nor the preset author to present <Label> and <link> elements for their guidance.

If such items popped up the normal panel, complete with any <label> and <link> elements and importantly, the "Apply Preset" button, then a safer and more helpful UI will result.

Attachments (0)

Change History (7)

comment:1 Changed 5 years ago by malcolmh

Description: modified (diff)

comment:2 Changed 5 years ago by Aun Johnsen <lists@…>

Cc: lists@… added

If there is still a need for "silent" accepting these <key> elements, maybe another element to force the apply button? <apply/>?

comment:3 Changed 5 years ago by stoecker

Resolution: worksforme
Status: newclosed

Simply add something else - e.g. a text to display.

comment:4 Changed 5 years ago by malcolmh

Resolution: worksforme
Status: closedreopened

Could you please provide your test case? I have an item with <key>, <label> and <link> elements, but no panel appears.

comment:5 Changed 5 years ago by stoecker

Resolution: fixed
Status: reopenedclosed

In 7525/josm:

fix #10499 - labels and links again result in display of presets

comment:6 Changed 5 years ago by Don-vip

Milestone: 14.09

comment:7 Changed 5 years ago by Polyglot

Thank you for still keeping the possibility to have actual one-click presets. My workflow integrating bus stops relies heavily on this. I had to remove the label tags from my presets XML file, but now it works again, the way I feel it should.

Polyglot

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.