Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10313 closed enhancement (fixed)

support for man_made=embankment

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 14.08
Component: Internal mappaint style Version:
Keywords: Cc: bastiK

Description

1) add it to preset
2) render it like natural=cliff
2+) render it like natural=cliff but in brown rather than in grey

see http://wiki.openstreetmap.org/wiki/Tag:man_made%3Dembankment and http://taginfo.openstreetmap.org/tags/?key=man_made&value=embankment

Attachments (2)

embankment.osm (30.5 KB) - added by skyper 5 years ago.
real world example
embankment_screenshot.png (127.9 KB) - added by skyper 5 years ago.
screenshot

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by Don-vip

Milestone: 14.08

comment:2 Changed 5 years ago by Don-vip

images added in [o30579].

comment:3 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7374/josm:

fix #10313 - support for man_made=embankment (plus rendering of embankment=yes)

comment:4 Changed 5 years ago by anonymous

Great, thanks!
Do I read the patch correctly, that if the man_made=embankment (or embankment=yes) is not on a a way with highway or railway or waterway then the arrows are rendered only on the right (per the wiki).
If it is on a highway or railway or waterway then the arrows are on both sides? Meaning the *way is on the embankment and both sides of it are lower. That would be fine.

comment:5 Changed 5 years ago by Don-vip

That's what I tried to do, yes. You can test for yourself with JOSM latest :)

comment:6 Changed 5 years ago by skyper

The rendering on ways (especially track) is way to prominent. Might be better with realwidth set but without you hardly recognize tracktype. This rendering also effects external styles which work as extension of the default style.

Maybe lower width and wider spacing will work.

Personally, I use both/left/right as values for embankment and cutting but numbers are low atm.

comment:7 Changed 5 years ago by Don-vip

Do you have a real world example, please?

comment:8 Changed 5 years ago by Don-vip

Cc: bastiK added

Paul, if you have some comments... :) I tried to mimic the behaviour of natural=cliff but maybe there are better ways to do it :)

comment:9 Changed 5 years ago by bastiK

Looks fine to me.

@skyper: both/left/right is out of question as long as the numbers are low and it isn't documented in the wiki.

Changed 5 years ago by skyper

Attachment: embankment.osm added

real world example

Changed 5 years ago by skyper

Attachment: embankment_screenshot.png added

screenshot

comment:10 in reply to:  9 Changed 5 years ago by skyper

Replying to bastiK:

Replying to Don-vip:
@skyper: both/left/right is out of question as long as the numbers are low and it isn't documented in the wiki.

I know.

Do you have a real world example, please?

Please have a look at the data file downloaded with overpass and the screenshot:

screenshot

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.