remove shop=yes and shop=no from presets

[mkoniecz]

shop=no simply should not be used and shop=yes is worse than any alternative

shop = vacant similar to shop=no is documented as discouraged at ​osmwiki:Key:shop

as shop=yes is used 23 523 time (over 1% of shops) and shop=no 2 233 times both deserve also validator warning.

[skyper]

shop=yes/no is used together with amenity=fuel. Mapper are encouraged to map amenity=fuel as area and to add an extra object for the shop but this is not possible with a single node.

[skyper]

I did some more investigations with ​overpass. How about removing shop=yes from the gas station preset. Maybe we can tweak auto completion to stop offering yes/no as values.

+1 for validator rules, especially for shop=yes/no/vacant without amenity=fuel.

[Don-vip]

Replying to skyper:

How about removing shop=yes from the gas station preset.

Is there a suitable shop value we could offer instead?

[skyper]

Replying to Don-vip:

Replying to skyper:

How about removing shop=yes from the gas station preset.

Is there a suitable shop value we could offer instead?

Well, should have included the line from defaultpresets.xml:

user@box:~$ grep '"shop"' defaultpresets.xml |grep no
<combo key="shop" text="With shop" values="yes,convenience,kiosk,no" />

We already offer kiosk and convenience. At least in my hemisphere I am not aware of any other common ones.

[Don-vip]

Most of shop=yes for this preset should be shop=convenience I think, so we could at least remove yes.

[mkoniecz]

Is it possible to suggest shop=yes/no only for objects tagged with amenity=fuel?

[aceman]

I also tag gas fuel stations as amenity=fuel (either node or the roof building over pumps) and the associated shop building as shop=convenience. So I would also suggest warning about shop=yes and remove it from JOSM presets. I understand users could tag shop=yes+amenity=fuel meaning the usual shop at fuel stations but sometimes there may be exceptions. E.g. does it only sell fuels or fuel-related goods? Does it also have food or gifts? It seems 'convenience' covers small shop with varied goods, including food. Or we should create a new shop value for the 'usual fuel station'.

[openstreetmap.org-user-d1g]

1. Yes, shop=yes shouldn't be suggested with gas stations (users have to tag convenience shops as a separate node)

But also:

2. "A shop of unspecified type." - ​osm wiki about shop=yes
3. iD supports shop=yes as "generic shop" (last time I used iD)

In 2016:

4. OsmAnd supports this tag ​shop=yes
5. shop=* (-shop=no -shop=disused) supported by ​https://github.com/gravitystorm/openstreetmap-carto/pull/2415

[openstreetmap.org-user-d1g]

Users should be warned during validation about shop=yes ("please pick more specific variant please"), similar how they warned about highway=road and fixme=* tags IMO

[skyper]

Meanwhile there is a warning for shop=yes as main tag and the shop combo in the fuel preset is editable. So, do not blame JOSM for the ​numbers.

In my point of view this is a "wontfix"