Modify

Opened 10 years ago

Last modified 4 years ago

#10310 new enhancement

remove shop=yes and shop=no from presets

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: shop amenity fuel Cc: Klumbumbus

Description (last modified by skyper)

shop=no simply should not be used and shop=yes is worse than any alternative

shop = vacant similar to shop=no is documented as discouraged at osmwiki:Key:shop

as shop=yes is used 23 523 time (over 1% of shops) and shop=no 2 233 times both deserve also validator warning.

Attachments (0)

Change History (12)

comment:1 by skyper, 10 years ago

shop=yes/no is used together with amenity=fuel. Mapper are encouraged to map amenity=fuel as area and to add an extra object for the shop but this is not possible with a single node.

comment:2 by skyper, 10 years ago

I did some more investigations with overpass. How about removing shop=yes from the gas station preset. Maybe we can tweak auto completion to stop offering yes/no as values.

+1 for validator rules, especially for shop=yes/no/vacant without amenity=fuel.

in reply to:  2 ; comment:3 by Don-vip, 10 years ago

Replying to skyper:

How about removing shop=yes from the gas station preset.

Is there a suitable shop value we could offer instead?

comment:4 by Don-vip, 10 years ago

Keywords: shop amenity fuel added

in reply to:  3 comment:5 by skyper, 10 years ago

Replying to Don-vip:

Replying to skyper:

How about removing shop=yes from the gas station preset.

Is there a suitable shop value we could offer instead?

Well, should have included the line from defaultpresets.xml:

user@box:~$ grep '"shop"' defaultpresets.xml |grep no
<combo key="shop" text="With shop" values="yes,convenience,kiosk,no" />

We already offer kiosk and convenience. At least in my hemisphere I am not aware of any other common ones.

Last edited 10 years ago by skyper (previous) (diff)

comment:6 by Don-vip, 10 years ago

Most of shop=yes for this preset should be shop=convenience I think, so we could at least remove yes.

comment:7 by mkoniecz, 10 years ago

Is it possible to suggest shop=yes/no only for objects tagged with amenity=fuel?

comment:8 by Klumbumbus, 9 years ago

Cc: Klumbumbus added

comment:9 by aceman, 9 years ago

I also tag gas fuel stations as amenity=fuel (either node or the roof building over pumps) and the associated shop building as shop=convenience. So I would also suggest warning about shop=yes and remove it from JOSM presets. I understand users could tag shop=yes+amenity=fuel meaning the usual shop at fuel stations but sometimes there may be exceptions. E.g. does it only sell fuels or fuel-related goods? Does it also have food or gifts? It seems 'convenience' covers small shop with varied goods, including food. Or we should create a new shop value for the 'usual fuel station'.

comment:10 by openstreetmap.org-user-d1g, 7 years ago

  1. Yes, shop=yes shouldn't be suggested with gas stations (users have to tag convenience shops as a separate node)

But also:

  1. "A shop of unspecified type." - osm wiki about shop=yes
  2. iD supports shop=yes as "generic shop" (last time I used iD)

In 2016:

  1. OsmAnd supports this tag shop=yes
  2. shop=* (-shop=no -shop=disused) supported by https://github.com/gravitystorm/openstreetmap-carto/pull/2415

comment:11 by openstreetmap.org-user-d1g, 7 years ago

Users should be warned during validation about shop=yes ("please pick more specific variant please"), similar how they warned about highway=road and fixme=* tags IMO

comment:12 by skyper, 4 years ago

Description: modified (diff)

Meanwhile there is a warning for shop=yes as main tag and the shop combo in the fuel preset is editable. So, do not blame JOSM for the numbers.

In my point of view this is a "wontfix"

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to mkoniecz.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.