Modify

Opened 5 years ago

Last modified 3 years ago

#10310 new enhancement

remove shop=yes and shop=no from presets

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: shop amenity fuel Cc: Klumbumbus

Description

shop=no simply should not be used and shop=yes is worse than any alternative

shop = vacant similar to shop=no is documented as discouraged at http://wiki.openstreetmap.org/wiki/Key:shop

as shop=yes is used 23 523 time (over 1% of shops) and shop=no 2 233 times both deserve also validator warning.

Attachments (0)

Change History (11)

comment:1 Changed 5 years ago by skyper

shop=yes/no is used together with amenity=fuel. Mapper are encouraged to map amenity=fuel as area and to add an extra object for the shop but this is not possible with a single node.

comment:2 Changed 5 years ago by skyper

I did some more investigations with overpass. How about removing shop=yes from the gas station preset. Maybe we can tweak auto completion to stop offering yes/no as values.

+1 for validator rules, especially for shop=yes/no/vacant without amenity=fuel.

comment:3 in reply to:  2 ; Changed 5 years ago by Don-vip

Replying to skyper:

How about removing shop=yes from the gas station preset.

Is there a suitable shop value we could offer instead?

comment:4 Changed 5 years ago by Don-vip

Keywords: shop amenity fuel added

comment:5 in reply to:  3 Changed 5 years ago by skyper

Replying to Don-vip:

Replying to skyper:

How about removing shop=yes from the gas station preset.

Is there a suitable shop value we could offer instead?

Well, should have included the line from defaultpresets.xml:

user@box:~$ grep '"shop"' defaultpresets.xml |grep no
<combo key="shop" text="With shop" values="yes,convenience,kiosk,no" />

We already offer kiosk and convenience. At least in my hemisphere I am not aware of any other common ones.

Last edited 5 years ago by skyper (previous) (diff)

comment:6 Changed 5 years ago by Don-vip

Most of shop=yes for this preset should be shop=convenience I think, so we could at least remove yes.

comment:7 Changed 5 years ago by mkoniecz

Is it possible to suggest shop=yes/no only for objects tagged with amenity=fuel?

comment:8 Changed 5 years ago by Klumbumbus

Cc: Klumbumbus added

comment:9 Changed 5 years ago by aceman

I also tag gas fuel stations as amenity=fuel (either node or the roof building over pumps) and the associated shop building as shop=convenience. So I would also suggest warning about shop=yes and remove it from JOSM presets. I understand users could tag shop=yes+amenity=fuel meaning the usual shop at fuel stations but sometimes there may be exceptions. E.g. does it only sell fuels or fuel-related goods? Does it also have food or gifts? It seems 'convenience' covers small shop with varied goods, including food. Or we should create a new shop value for the 'usual fuel station'.

comment:10 Changed 3 years ago by openstreetmap.org-user-d1g

  1. Yes, shop=yes shouldn't be suggested with gas stations (users have to tag convenience shops as a separate node)

But also:

  1. "A shop of unspecified type." - osm wiki about shop=yes
  2. iD supports shop=yes as "generic shop" (last time I used iD)

In 2016:

  1. OsmAnd supports this tag shop=yes
  2. shop=* (-shop=no -shop=disused) supported by https://github.com/gravitystorm/openstreetmap-carto/pull/2415

comment:11 Changed 3 years ago by openstreetmap.org-user-d1g

Users should be warned during validation about shop=yes ("please pick more specific variant please"), similar how they warned about highway=road and fixme=* tags IMO

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to mkoniecz
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.