Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10300 closed enhancement (fixed)

Add field for addr:suburb to address preset

Reported by: daganzdaanda Owned by: team
Priority: normal Milestone: 14.08
Component: Internal preset Version: tested
Keywords: Address Cc:

Description

Hi,

I propose to add
addr:suburb
to the internal address preset.

Currently, there are fields for
addr:housenumber
addr:housename
addr:street
addr:city
addr:postcode
addr:country

In my area (Bavaria), there are a lot of cities and towns that include a number of villages as suburbs.
The addr:suburb tag is used in addresses there, because addr:city is always the main city. I'd love to be able to enter all this in the same dialogue.

Attachments (0)

Change History (20)

comment:1 Changed 5 years ago by daganzdaanda

...come to think of it, maybe the address preset could be customizeable by the user?
So that everybody gets quick access to the addr:* tags they use most, and can hide the tags they do not need. E.g. in Germany there is no official "addr:housename", but in the UK it is quite common. Or, "addr:state" is used in the US, but not here.

comment:2 Changed 5 years ago by daganzdaanda

I've found the address-plugin in defaultpresets.xml

Would adding this line:

<text key="addr:suburb" text="Suburb" use_last_as_default="force" match="key" />

after

https://josm.openstreetmap.de/browser/josm/trunk/data/defaultpresets.xml#L6820

be enough for now?
Full customization is probably not quite as simple.

comment:3 Changed 5 years ago by daganzdaanda

Any opinon on this?

comment:4 Changed 5 years ago by Don-vip

Milestone: 14.08

comment:5 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7399/josm:

fix #10300 - add country-specific optional address attributes (addr:hamlet, addr:suburb, addr:subdistrict, addr:district, addr:state)

comment:6 Changed 5 years ago by aceman

Is addr:place already in the list? It seems to be used much more widely.

comment:7 Changed 5 years ago by Don-vip

In 7410/josm:

see #10300 - add addr:place

comment:8 Changed 5 years ago by daganzdaanda

Thank you very much!

I think for Canada and some other countries, addr:province is used (you have "US/Canadian States as defined in ISO 3166-2" for addr:state)

<http://taginfo.openstreetmap.org/search?q=addr> has some widely used tags that I've never seen before:
addr:conscriptionnumber (> 2 million uses, mostly in CZ)
addr:streetnumber and addr:provisionalnumber seem to belong in the Czech system as well.

From the wiki <http://wiki.openstreetmap.org/wiki/Key:addr>, maybe addr:flats addr:unit and addr:door would make sense?

comment:9 Changed 5 years ago by Don-vip

I forgot province, that's right. I won't add the others, they're not used much. Neither the czech one, not documented.

comment:10 Changed 5 years ago by Don-vip

In 7430/josm:

see #10300 - add addr:province

comment:11 Changed 5 years ago by daganzdaanda

OK, thanks a lot!
You still have the Canadian provinces in the combo-list of states (at the end).
AB,BC,MB,NB,NL,NS,ON,PE,QC,SK,NT,NU,YT
I don't think adding an extra combo list for Canada is necessary. Province is used in more countries than CA, as taginfo shows.

Btw, when I use the addr:street field, I get all kinds of names as suggestions for autocomplete. Is there a way to restrict the suggestions to names of streets? This is the line in the code:
<text key="addr:street" text="Street name" use_last_as_default="force" match="key" alternative_autocomplete_keys="name" />

comment:12 Changed 5 years ago by Don-vip

Indeed. I messed up Canadian provinces and US states as they use the same postal abbreviation system.

comment:13 Changed 5 years ago by Don-vip

In 7431/josm:

see #10300 - remove Canadian provinces from the list of addr:states

comment:14 in reply to:  9 Changed 5 years ago by aceman

Replying to Don-vip:

I forgot province, that's right. I won't add the others, they're not used much. Neither the czech one, not documented.

That is fine, the CZ & SK addressing schema is covered at
https://josm.openstreetmap.de/josmfile?page=Presets/Czech_Slovak_addresses&preset

comment:15 in reply to:  12 ; Changed 5 years ago by frankthetankk

Replying to Don-vip:

Indeed. I messed up Canadian provinces and US states as they use the same postal abbreviation system.

You listed "DC,AS,GU,MP,PR,UM,VI" as part of the 50 U.S. States should be removed. These are list as a Insular area. They are independent nations, that participate with the U.S. State Department. Here are the 50 U.S. States

Last edited 5 years ago by frankthetankk (previous) (diff)

comment:17 in reply to:  15 ; Changed 5 years ago by Don-vip

Replying to frankthetankk:

Replying to Don-vip:

Indeed. I messed up Canadian provinces and US states as they use the same postal abbreviation system.

You listed "DC,AS,GU,MP,PR,UM,VI" as part of the 50 U.S. States should be removed. These are list as a Insular area. They are independent nations, that participate with the U.S. State Department.

I understand they are not proper incorporated states, but I used List_of_U.S._state_abbreviations and these abbreviations are defined as such in ISO, ANSI, USPS and USCG standards. As we're talking about an address here, doesn't it make sense to reuse abbreviations used by USPS? I assume if you want to send a letter to someone living in Puerto Rico for example, you'd use "PR" as state abbreviation to make USPS ship that letter, no?

Last edited 5 years ago by Don-vip (previous) (diff)

comment:18 Changed 5 years ago by Don-vip

See official USPS documentation #1 and #2 about Puerto Rico addresses. I'd prefer to keep these entries.

Last edited 5 years ago by Don-vip (previous) (diff)

comment:19 in reply to:  17 Changed 5 years ago by frankthetankk

Replying to Don-vip:

Replying to frankthetankk:

Replying to Don-vip:

Indeed. I messed up Canadian provinces and US states as they use the same postal abbreviation system.

You listed "DC,AS,GU,MP,PR,UM,VI" as part of the 50 U.S. States should be removed. These are list as a Insular area. They are independent nations, that participate with the U.S. State Department.

I understand they are not proper incorporated states, but I used List_of_U.S._state_abbreviations and these abbreviations are defined as such in ISO, ANSI, USPS and USCG standards. As we're talking about an address here, doesn't it make sense to reuse abbreviations used by USPS? I assume if you want to send a letter to someone living in Puerto Rico for example, you'd use "PR" as state abbreviation to make USPS ship that letter, no?

That's fine with me. Just trying to help if you make a mistake. :)

comment:20 Changed 5 years ago by Don-vip

No problem :) It's always great to have feedback from people living in other countries :)

comment:21 Changed 5 years ago by daganzdaanda

Hi again,
the German translation is not yet perfect. I have started a thread http://forum.openstreetmap.org/viewtopic.php?id=26830 to find a good translation especially for addr:place. I will change the translation myself, after I get some feedback.

But there's something else:
addr:housename is, according to the wiki, mainly a UK thing. Should it be moved to the second group of tags?
I see many addr:housename tags in Germany, where it's mostly wrongly used instead of name/old_name/loc_name/...

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.