Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10252 closed defect (fixed)

strange display of route=bus on roads

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 14.11
Component: Internal mappaint style Version:
Keywords: Cc:

Description (last modified by mkoniecz)

highway=unclassified with route=bus tag is displayed as a dashed line.

I would expect that the mappaint style would not consider this tag in selecting way style.

Note that according to http://wiki.openstreetmap.org/wiki/Tag:route%3Dbus these tag should be used on relations.

Validator is currently not reporting any problems on ways like this.

example: https://www.openstreetmap.org/way/26257519

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-07-09 01:37:29
Last Changed Author: bastiK
Revision: 7296
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-07-08 18:49:07 +0200 (Tue, 08 Jul 2014)
Last Changed Rev: 7296

Identification: JOSM/1.5 (7296 en) Windows 7 32-Bit
Memory Usage: 156 MB / 247 MB (35 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30416)
Plugin: RoadSigns (30495)
Plugin: buildings_tools (30485)
Plugin: continuosDownload (28565)
Plugin: measurement (30416)
Plugin: notes (v0.9.2)
Plugin: turnrestrictions (30454)
Plugin: wikipedia (30449)

Attachments (0)

Change History (11)

comment:1 Changed 5 years ago by mkoniecz

Description: modified (diff)

comment:2 Changed 5 years ago by Klumbumbus

We're talking about this part of code:

way[route=bus],
way[route=ferry],
way[route=flight],
way[route=ncn],
way[route=subsea],
way[route=ski],
way[route=tour],
way[route=pub_crawl] {
    width: 1;
    color: route#809bc0;
    dashes: 9,9;
}
  • We should simply remove flight, ncn, subsea, tour and pub_crawl, because they do not make sense and are not really used (they are left from the early days of JOSM).
  • We should remove bus and add a validator message for this to use an relation instead.
  • We should keep ferry, because this is the correct way to tag ferry routes
  • I'm not sure about ski. In my opinion a relation is better instead of tagging it directly on the way (wiki says the same). There is also the newer scheme route=piste. So I would also just drop the rendering of ways with route=ski. However there are 4711 ways with route=ski in the database taginfo. Any opinions about this?
Last edited 5 years ago by Klumbumbus (previous) (diff)

comment:3 in reply to:  2 Changed 5 years ago by skyper

Replying to Klumbumbus:

  • We should simply remove flight, ncn, subsea, tour and pub_crawl, because they do not make sense and are not really used (they are left from the early days of JOSM).
  • We should remove bus and add a validator message for this to use an relation instead.
  • We should keep ferry, because this is the correct way to tag ferry routes

Agree with above.

  • I'm not sure about ski. In my opinion a relation is better instead of tagging it directly on the way (wiki says the same). There is also the newer scheme route=piste. So I would also just drop the rendering of ways with route=ski. However there are 4711 ways with route=ski in the database taginfo. Any opinions about this?

Think there is no problem with tagging it on the way, especially in cases where there is no highway "underneath".
A relation is only needed if you want to tag more details like adding a name, colour or ref but still incline and difficulty might be tag for the single ways.

As we find several pistes with mixed use it was decided to use the more general value which does not mean that the more specific value is wrong and currently it is used more often.
Think for a clean up (e.g. validator warnings) we need to find good arguments and a discussion at tagging@ in advance.

By the way, above mentioned wiki page about route=ski seems to be unmaintained as it missing lots of links and a good description and was not changed much in the last four years.

comment:4 Changed 5 years ago by Klumbumbus

So I suggest to keep way[route=ski] and move it to the ::core_piste layer and make the rendering similar to the piste:difficulty=*tags. This way it does not create weird rendering if used on a way with e.g. highway=*.

comment:5 in reply to:  4 Changed 5 years ago by skyper

Replying to Klumbumbus:

So I suggest to keep way[route=ski] and move it to the ::core_piste layer and make the rendering similar to the piste:difficulty=*tags. This way it does not create weird rendering if used on a way with e.g. highway=*.

+1

comment:6 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 7645/josm:

fix #10252 - remove some old route=* tags from mappaint style; improve display of route=ski; add validator warning for route=bus on a way

comment:7 Changed 5 years ago by Klumbumbus

Milestone: 14.11

comment:8 Changed 5 years ago by aceman

OK, if you add warning for route=bus, what about doing the same for other types of on-ground transport? Like tram, trolleybus, etc?

comment:9 Changed 5 years ago by Klumbumbus

Maybe there is some wiki clean up needed before, especially this table and the different Tag:route=* pages.
In my opinion all route=* (except ferry) should always be in relations. But I can imagine that there is also the opinion to tag small routes directly on the way, example: way/48405645.

However I think we can safely add a warning for route=* on nodes (there are 4 647 of those!)

comment:10 in reply to:  9 Changed 5 years ago by skyper

Replying to Klumbumbus:

Maybe there is some wiki clean up needed before, especially this table and the different Tag:route=* pages.

Did clean up the easy part.

In my opinion all route=* (except ferry) should always be in relations. But I can imagine that there is also the opinion to tag small routes directly on the way, example: way/48405645.

+1 we need to discuss this with wider audience, though

Had a deeper look at the ways and many seem to be used for quite a number of sport activities.

However I think we can safely add a warning for route=* on nodes (there are 4 647 of those!)

+1, many are left-over of incomplete bus tagging.

comment:11 Changed 5 years ago by Klumbumbus

In 7651/josm:

see #10252 - add warning for route=* on nodes

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.