Changes between Initial Version and Version 1 of Ticket #10205, comment 10


Ignore:
Timestamp:
2020-12-03T10:40:43+01:00 (5 years ago)
Author:
GerdP

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10205, comment 10

    initial v1  
    11It's quite tricky. The method `Geometry.getCenter()` is used to calculate the center of the circle. IIGTR the algo used in this method is meant to be used with the nodes of a polygon which is not self-intersecting, the order of the nodes would be that of a closed way (first node == last node)
    2 If only nodes are selected the code in `AlignInCircleAction` doesn't sort the nodes and thus the result of the center calculation is more or less unpredictable. The code itself documents this a possible selection: "Align these nodes, all are fix" but obviously the code doesn't work well and this selection is also not documented in the wiki wiki:Help/Action/AlignInCircle
     2If only nodes are selected the code in `AlignInCircleAction` doesn't sort the nodes and thus the result of the center calculation is more or less unpredictable. The code itself documents this a possible selection: "Align these nodes, all are fix" but obviously the code doesn't work well ~~and this selection is also not documented in the wiki~~ wiki:Help/Action/AlignInCircle
    33I see no real use case for this selection, so I think we should simply reject a selection that contains only nodes.