Opened 10 years ago

Closed 10 years ago

#10133 closed enhancement (fixed)

add "route" role (to presets?)

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 14.12
Component: Core validator Version:
Keywords: route relation empty role Cc:

Description (last modified by mkoniecz)

According to empty or "route" role should be used for ways making up the route.

Currently using empty results in "Empty role found" ( ) and "route" in "Role route unknown" ( ).

Probably the second version should be encouraged and should not result "Role verification problem" warning from validator.

Repository Root:
Build-Date: 2014-06-10 01:34:35
Last Changed Author: Don-vip
Revision: 7235
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Date: 2014-06-10 01:09:36 +0200 (Tue, 10 Jun 2014)
Last Changed Rev: 7235

Identification: JOSM/1.5 (7235 en) Windows 7 32-Bit
Memory Usage: 784 MB / 784 MB (224 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Xmx812M]

Dataset consistency test:
[WARN - NO NODES] Way {Way id=266461110 version=2 VT nodes=[{Node id=30371655 version=9 V lat=50.0719727,lon=19.8024335}]} has only one node

Plugin: OpeningHoursEditor (30416)
Plugin: RoadSigns (30438)
Plugin: buildings_tools (30485)
Plugin: continuosDownload (28565)
Plugin: lakewalker (30416)
Plugin: measurement (30416)
Plugin: notes (v0.9.2)
Plugin: wikipedia (30449)

Attachments (0)

Change History (8)

comment:1 by mkoniecz, 10 years ago

Description: modified (diff)
Summary: add "route" role unknown (to presets?)add "route" role (to presets?)

comment:2 by mkoniecz, 10 years ago

Description: modified (diff)

comment:3 by mkoniecz, 10 years ago

Description: modified (diff)

comment:4 by Klumbumbus, 10 years ago

There are a lot route relations with ways which have empty roles. In my opinion JOSM should not warn about this. Also the role "route" was not used from the beginning.

comment:5 by simon04, 10 years ago

The patch from ticket:9844#comment:11 seems to fix this issue …

comment:6 by Don-vip, 10 years ago

Keywords: route relation empty role added

comment:7 by Don-vip, 10 years ago

Milestone: 14.12

comment:8 by Don-vip, 10 years ago

Resolution: fixed
Status: newclosed

In 7884/josm:

fix #9844, fix #9992, fix #10133 - fix relation checker tests against member expressions (modified patch by wiktorn)

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.