Opened 5 years ago
Closed 5 years ago
#19169 closed enhancement (fixed)
[PATCH] Modify JavaFxWrapper to better report initialization errors
Reported by: | taylor.smock | Owned by: | Don-vip |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Plugin javafx | Version: | |
Keywords: | Cc: |
Description
#19044 is getting hit more, and it would be nice to be able to detect the error and fall back to some other behavior (as well as getting a better stack trace).
The patch was originally added to #19114 as a possible method to get a better stack trace, and has been modified to also help plugins fall back to something else instead of crashing (by possibly throwing an exception during initialization).
The better stack trace comes from submitting a FutureTask to the JavaFx Platform.runLater and then performing a get
on the FutureTask. This should not cause a block in the threads, since the class should not be instantiated inside of the JavaFx Platform thread.
In order to avoid having a bug report on specific exceptions (currently only NoClassDefFoundError
), they are logged but not sent to the main handler.
TBH, I'd prefer to properly fix #19044, but adding --add-opens=jdk.unsupported.desktop/jdk.swing.interop=ALL_UNNAMED
to the jnlp
java-vm-args
didn't help.
Attachments (1)
Change History (2)
by , 5 years ago
Attachment: | 19169.patch added |
---|
comment:1 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
[o35492:35493]
Thank you!